D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-16 Thread Jonah Brüchert 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:eb364c963630: Compensate smaller icon sizes on mobile in 
the ActionButton (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23941?vs=66040&id=66202

REVISION DETAIL
  https://phabricator.kde.org/D23941

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-14 Thread Jonah Brüchert 
jbbgameich added a comment.


  I believe the new icon sizes were intentional for the drawer and own uses of 
Kirigami.Icon, but they influence the size of the whole ActionButton as well 
making it rather hard to click on a touch screen.
  Probably Camilo tested his changes only with mauikit which doesn't even use 
the bottom action nuttons.
  
  F7351130: Screenshot_20190914-175603.png 

  (I had to hide some jabber ids in my contact list, I hope the action buttons 
are still visible properly)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23941

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-14 Thread Nathaniel Graham 
ngraham added a comment.


  I thought the smaller sizes now were intentional?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23941

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-14 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  They became smaller since D22572 . This 
should restore the intended state.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23941

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein