D23952: Remove panel toolbox and clean up editing options

[Björn Feber]

GB_2 planned changes to this revision.
GB_2 added a comment.


  In D23952#532716 , @ngraham wrote:
  
  > I agree that we can't only have this UI be in a context menu, and we need 
to expose it somewhere visible too (i.e. in System Settings like we discussed 
at the Plasma + Usability & Productivity sprint.
  >
  > I kind of like not showing the configure button in the panel though. It 
bugs the heck out of me and break's Fitts' law for the screen corner pixel that 
it appears next to, which is particularly unfortunate as we now do ship a 
widget that benefits from being activated by a screen corner pixel (Show 
Desktop).
  
  
  Ok, let's wait with removing the panel toolbox then until we expose it 
somewhere else.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23952: Remove panel toolbox and clean up editing options

[Nathaniel Graham]

ngraham added a comment.


  I agree that we can't only have this UI be in a context menu, and we need to 
expose it somewhere visible too (i.e. in System Settings like we discussed at 
the Plasma + Usability & Productivity sprint.
  
  I kind of like not showing the configure button in the panel though. It bugs 
the heck out of me and break's Fitts' law for the screen corner pixel that it 
appears next to, which is particularly unfortunate as we now do ship a widget 
that benefits from being activated by a screen corner pixel (Show Desktop).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23952: Remove panel toolbox and clean up editing options

[Marco Martin]

mart added a comment.


  moreover, as i plan to do with the desktop one, it should still be there, 
just not shown in non-edit mode

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23952: Remove panel toolbox and clean up editing options

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  i'm in general not in favor of having only right click.
  this patch will be fine, only after the global edit mode button will be in 
systemsettings.
  That is an absolute blocker for me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg, mart
Cc: mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23952: Remove panel toolbox and clean up editing options

[Björn Feber]

GB_2 updated this revision to Diff 66159.
GB_2 added a comment.


  - Add back "Show Alternatives..." item and remove reference to panel toolbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23952?vs=66105&id=66159

BRANCH
  arcpatch-D23952

REVISION DETAIL
  https://phabricator.kde.org/D23952

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
  desktoppackage/contents/defaults
  toolboxes/CMakeLists.txt
  toolboxes/paneltoolbox/Messages.sh
  toolboxes/paneltoolbox/contents/ui/main.qml
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Nathaniel Graham]

ngraham added a comment.


  Oh, of course.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Björn Feber]

GB_2 added a comment.


  In D23952#532034 , @ngraham wrote:
  
  > Hmm, after applying and compiling all three patches and then restarting 
plasmashell, I still see the panel toolbox.
  
  
  That's because you still have the files and manually compiling and installing 
won't delete them :-)
  The package manager does that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23952: Remove panel toolbox and clean up editing options

[Nathaniel Graham]

ngraham added a comment.


  Hmm, after applying and compiling all three patches and then restarting 
plasmashell, I still see the panel toolbox.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23952

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart