D23980: [Folder View] Don't explicitly initialize fontMetrics

2019-09-18 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:eb9c5f32edbc: [Folder View] Don't explicitly 
initialize fontMetrics (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23980?vs=66186&id=66356

REVISION DETAIL
  https://phabricator.kde.org/D23980

AFFECTED FILES
  containments/desktop/plugins/folder/rubberband.cpp

To: broulik, #plasma, hein, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23980: [Folder View] Don't explicitly initialize fontMetrics

2019-09-16 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Oh boy, wow.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23980

To: broulik, #plasma, hein, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23980: [Folder View] Don't explicitly initialize fontMetrics

2019-09-16 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `qApp->fontMetrics()` calls `desktop()` which creates a `QDesktopWidget` and 
might do so on a non-main thread in case of threaded rendering.
  
  BUG: 411953
  FIXED-IN: 5.12.10

TEST PLAN
  - Verified that the default-initialized `opt.fontMetrics` matches the 
`qApp->fontMetrics()`
  
  - Rubber band still looks normal

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23980

AFFECTED FILES
  containments/desktop/plugins/folder/rubberband.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart