D24005: Show a new version string description for updates where the old and new versions are identical
This revision was automatically updated to reflect the committed changes. Closed by commit R134:482e2b4038f8: Show a new version string description for updates where the old and new… (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24005?vs=66306&id=66307 REVISION DETAIL https://phabricator.kde.org/D24005 AFFECTED FILES discover/qml/UpdatesPage.qml To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D24005: Show a new version string description for updates where the old and new versions are identical
ngraham updated this revision to Diff 66306. ngraham added a comment. Add a happy little comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24005?vs=66305&id=66306 BRANCH new-version-string-presentation (branched from master) REVISION DETAIL https://phabricator.kde.org/D24005 AFFECTED FILES discover/qml/UpdatesPage.qml To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D24005: Show a new version string description for updates where the old and new versions are identical
ngraham updated this revision to Diff 66305. ngraham added a comment. Use only a single string REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24005?vs=66257&id=66305 BRANCH new-version-string-presentation (branched from master) REVISION DETAIL https://phabricator.kde.org/D24005 AFFECTED FILES discover/qml/UpdatesPage.qml To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D24005: Show a new version string description for updates where the old and new versions are identical
apol added a comment. Having 3 identical labels with slightly different conditions feels odd, maybe we should just take it into account if when assigning the property? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24005 To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D24005: Show a new version string description for updates where the old and new versions are identical
ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is common for Flatpak runtime updates, where it seems weird to show "3.34 -> 3.34". With this patch, instead Discover will show "Update to version 3.34", which is more accurate. TEST PLAN No change for updates where old and new are different or only new version is available Could not test with an update where old and new are the same (only got the idea after applying an update today where this happened); will test with the next such update REPOSITORY R134 Discover Software Store BRANCH new-version-string-presentation (branched from master) REVISION DETAIL https://phabricator.kde.org/D24005 AFFECTED FILES discover/qml/UpdatesPage.qml To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
