D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Maxim Marshev 
maximma updated this revision to Diff 66913.
maximma added a comment.


  Bug Fix 410988

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24146?vs=66694=66913

BRANCH
  calculatorApplet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24146

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Maxim Marshev 
maximma added a comment.


  ok

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Nathaniel Graham 
ngraham added a comment.


  Change the files to remove those changes using your text editor, then run 
`arc diff`.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Maxim Marshev 
maximma added a comment.


  ok, how remove changes from those path?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Nathaniel Graham 
ngraham added a comment.


  If there are three changes necessary (fix display, fix bug, change C 
behavior) then we need three patches in a dependency chain. :) See 
https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Maxim Marshev 
maximma added a comment.


  In D24146#538295 , @ngraham wrote:
  
  > Make a second patch that only fixes the bug, and then remove those changes 
from this patch.
  
  
  Do I need to create another page with only bug fix? Or do I need to make 
another commit only with bug fix? What to do with the correction of the display 
of numbers? Because I need changes that are in fixing the bug.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Nathaniel Graham 
ngraham added a comment.


  Make a second patch that only fixes the bug, and then remove those changes 
from this patch.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Maxim Marshev 
maximma added a comment.


  In D24146#538292 , @ngraham wrote:
  
  > In D24146#538284 , @maximma 
wrote:
  >
  > >
  >
  >
  > Excellent. Could you split this out so we have two patches:
  
  
  Yes, could you explain?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Nathaniel Graham 
ngraham added a comment.


  In D24146#538284 , @maximma wrote:
  
  > 1. I am not sure where the description window is.
  
  
  You can click on the Edit Revision button to add stuff to the description.
  
  > 2. Yes, this fixes this bug. I am not sure how much this is the right 
solution, because I am not familiar with js at a sufficient level. But having 
considered all the solutions, I realized that this is one of the simplest 
solutions. I can’t explain correctly, so I’ll give an example. The user enters 
a number, say "102.03200". In memory, this will be stored as 10203200 and 5. 
That is, to get the number back we need 10203200/10 ^ 5. It also fixes a bug 
with the display of numbers. And the "C" button does the same as the "AC", 
because before that, when I clicked on "C" and further calculations, the answer 
was incorrect or the "C" button seemed not obvious to me.
  
  Excellent. Could you split this out so we have two patches:
  
  - One that fixes https://bugs.kde.org/show_bug.cgi?id=410988
  - Another one (this one?) that makes C do the same thing as AC

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Maxim Marshev 
maximma added a comment.


  1. I am not sure where the description window is.
  2. Yes, this fixes this bug. I am not sure how much this is the right 
solution, because I am not familiar with js at a sufficient level. But having 
considered all the solutions, I realized that this is one of the simplest 
solutions. I can’t explain correctly, so I’ll give an example. The user enters 
a number, say "102.03200". In memory, this will be stored as 10203200 and 5. 
That is, to get the number back we need 10203200/10 ^ 5.
  
  It also fixes a bug with the display of numbers. And the "C" button does the 
same as the "AC", because before that, when I clicked on "C" and further 
calculations, the answer was incorrect or the "C" button seemed not obvious to 
me.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-26 Thread Nathaniel Graham 
ngraham added reviewers: Plasma, cfeck.
ngraham added a comment.


  1. This needs more explanation in the Description section to indicate why the 
proposed change is a good idea.
  2. This seems like it has some unrelated changes in it, which look 
worthwhile, but they should be in a separate patch. Is this fixing 
https://bugs.kde.org/show_bug.cgi?id=410988?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24146

To: maximma, #plasma, cfeck
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-23 Thread Maxim Marshev 
maximma updated this revision to Diff 66694.
maximma added a comment.


  Fixed display of numbersА

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24146?vs=66625=66694

BRANCH
  calculatorApplet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24146

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: maximma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-22 Thread Maxim Marshev 
maximma created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
maximma requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  calculatorApplet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24146

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: maximma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart