D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now we have a problem in that the important scale factors of 1.25 and 
1.75 are
  not reachable using the UI. However just reducing the slider increment to 
0.05 would
  result in way too many slider values. Instead, this patch implements the 
following:
  
  - Slider goes by increments of 0.25
  - The user can show an advanced scaling settings dialog that exposes a UI to 
set the scale factor with increments of 0.05
  
  This way the commonly-used scale factors are more accessible, but more 
granular values
  are made available to people who really need them and are likely to go poking 
around.
  
  BUG: 412447
  FIXED-IN: 5.18.0

TEST PLAN
  F7477024: advanced scaling settings.webm 


REPOSITORY
  R104 KScreen

BRANCH
  advanced-scaling-control (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24321

AFFECTED FILES
  kcm/package/contents/ui/CustomScalingSheet.qml
  kcm/package/contents/ui/OutputPanel.qml
  kcm/package/contents/ui/Panel.qml
  kcm/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  0.05 is no good idea either ;)
  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  If we really need something finer than 0.25, could we stick with 1/8 or 1/16?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540011 , @cullmann wrote:
  
  > 0.05 is no good idea either ;)
  >  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  >  If we really need something finer than 0.25, could we stick with 1/8 or 
1/16?
  
  
  I don't want to lock people out of the finer scale factor numbers. Depending 
on your screen DPI and size, you may want to set and be quite happy with a 
weird scale factor like 1.65x. The idea here is to expose the more common and 
bug-free scale factors in the main UI, while letting experts and risk-takers 
set whatever they want. Maybe I should add a warning in the dialog that people 
who set a weird value there are on their own?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Noah Davis]

ndavis added a comment.


  what would be wrong with replacing the label with the spinbox? For normal 
control, use the slider. For fine control, use the spinbox. Then we wouldn't 
need an extra dialog.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540015 , @ndavis wrote:
  
  > what would be wrong with replacing the label with the spinbox? For normal 
control, use the slider. For fine control, use the spinbox. Then we wouldn't 
need an extra dialog.
  
  
  That isn't a bad idea, but then it feels a bit redundant since you'd have two 
adjacent controls that set the same value.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Björn Feber]

GB_2 added a comment.


  The KDE HIG suggests something like this: 
https://hig.kde.org/_images/Slider.Speed.qml.png

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[KonqiDragon]

KonqiDragon added a comment.


  How about breeze icon of SimpleScreenRecorder  #VDG 
?
  Maybe repaint digiKam icon to make SSR icon?
  F7477107: Breezeicons-apps-48-digikam.svg.png 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540014 , @ngraham wrote:
  
  > In D24321#540011 , @cullmann 
wrote:
  >
  > > 0.05 is no good idea either ;)
  > >  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  > >  If we really need something finer than 0.25, could we stick with 1/8 or 
1/16?
  >
  >
  > I don't want to lock people out of the finer scale factor numbers. 
Depending on your screen DPI and size, you may want to set and be quite happy 
with a weird scale factor like 1.65x. The idea here is to expose the more 
common and bug-free scale factors in the main UI, while letting experts and 
risk-takers set whatever they want. Maybe I should add a warning in the dialog 
that people who set a weird value there are on their own?
  
  
  That is fine, but please use some step width that is a proper float.
  Just use 1/16, that is 0,0625.
  0.05 will just lead to the same issues as 0.1, it looks nice in the input 
field but is no floating pointer number you can calculate sanely with.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Noah Davis]

ndavis added a comment.


  In D24321#540029 , @KonqiDragon 
wrote:
  
  > How about breeze icon of SimpleScreenRecorder  #VDG 
?
  >  Maybe repaint digiKam icon to make SSR icon?
  >  F7477107: Breezeicons-apps-48-digikam.svg.png 

  
  
  I think you accidentally posted in the wrong discussion.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  And the custom scale factor dialog really should have some warning text like 
on Windows ;=)
  
  see e.g.
  
  
https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html
  
  (custom scale factor not recommended)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Noah Davis]

ndavis added a comment.


  In D24321#540034 , @cullmann wrote:
  
  > And the custom scale factor dialog really should have some warning text 
like on Windows ;=)
  >
  > see e.g.
  >
  > 
https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html
  >
  > (custom scale factor not recommended)
  
  
  Ah, if it's not recommended, that might be a good reason to keep it in a 
separate dialog.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  In D24321#540026 , @GB_2 wrote:
  
  > The KDE HIG suggests something like this: 
https://hig.kde.org/_images/Slider.Speed.qml.png
  
  
  I kind of like this idea. Then if you set a weird value, an InlineMessage at 
the top of the screen would appear warning you that it's not a recommended 
value.
  
  Also without any string changes, it would go into Plasma 5.17. :)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Btw., I think GNOME is more clever than us, too, they allow just sane 
scalings in the UI:
  
  https://www.omgubuntu.co.uk/2019/06/enable-fractional-scaling-ubuntu-19-04

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Johan Ouwerkerk]

ouwerkerk added a comment.


  Ideally you would also warn if the reciprocal times the horizontal, vertical 
resolution yields a non-integer output, not just if some value is chosen which 
cannot be represented in floating point exactly.
  
  E.g. on a 4K (3840 × 2160) a scaling factor of 1.5 is fine because the 
horizontal resolution scales down to effectively 3840 × 2 ÷ 3 = 2160 and the 
vertical resolution scales down to 2160 × 2 ÷ 3 = 1440. This means that the 
scaled renders will fit the physical display exactly.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Johan Ouwerkerk]

ouwerkerk added a comment.


  Also side note, as a non-native English speaker I find "grossly" to be a bit 
of an odd adjective to use here -- "coarsely" would be more familiar: as in 
fine/coarse grained. Perhaps something to keep in mind when this lands and you 
start blogging about it :)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[David Edmundson]

davidedmundson added a comment.


  > it would go into Plasma 5.17. :)
  
  There's still a feature freeze.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Nathaniel Graham]

ngraham added a comment.


  No you're right, "grossly" is a poor choice of wording.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart