D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Nathaniel Graham]

ngraham updated this revision to Diff 68050.
ngraham added a comment.


  Rebase

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24373?vs=67226&id=68050

BRANCH
  0625-increment-on-x11

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Roman Gilg]

romangg added a comment.


  Actually I would like to expose the fact that we are doing that only on X11. 
People not knowing what this is can ignore it. Also it is a single factor, not 
multiple as with multi output DPI scaling on Wayland.
  
  How about:
  
The global scale factor is limited to multiples of 6.25% to minimize visual 
glitches in applications on the X11 windowing system.

REPOSITORY
  R104 KScreen

BRANCH
  0625-increment-on-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg, mart
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Nathaniel Graham]

ngraham updated this revision to Diff 67226.
ngraham added a comment.


  Don't mention X11; it's too nerdy and technical

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24373?vs=67218&id=67226

BRANCH
  0625-increment-on-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Christoph Cullmann]

cullmann added a comment.


  I would just reformulate
  
  "Scale factors are limited to multiples of 6.25% on X11 to minimize visual 
glitches in applications."
  
  to
  
  "Scale factors are limited to multiples of 6.25% to minimize visual glitches 
in applications."
  
  I think adding X11 only makes this harder to understand for the users.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Nathaniel Graham]

ngraham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Because of the nature of floating point math and various Qt and X11 bugs, 
limiting the
  scale factor increment to 0.0625 (6.25% in percentage form) will improve the 
display in
  many apps.
  
  For more information, see https://bugreports.qt.io/browse/QTBUG-66036 and the 
discussion
  in https://bugs.kde.org/show_bug.cgi?id=412447 and the following application 
bug reports:
  CCBUG: 390451
  CCBUG: 373232
  
  Depends on D24370 
  Depends on D24371 

TEST PLAN
  F7500922: 0625.png 

REPOSITORY
  R104 KScreen

BRANCH
  0625-increment-on-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24373

AFFECTED FILES
  kcm/package/contents/ui/Panel.qml
  kded/output.cpp

To: ngraham
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart