D24447: Fix compatibility of build_theme.sh with Dash

2019-10-15 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:91c16f284c18: Fix compatibility of build_theme.sh with 
Dash (authored by gepardo, committed by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24447?vs=67392=68004

REVISION DETAIL
  https://phabricator.kde.org/D24447

AFFECTED FILES
  src/build_theme.sh

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24447: Fix compatibility of build_theme.sh with Dash

2019-10-15 Thread Carson Black
cblack added a comment.


  In D24447#547774 , @gepardo wrote:
  
  > Thanks. Can you please merge it? I don't have a developer access to KDE 
repos.
  
  
  Sure, I'll do that.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24447: Fix compatibility of build_theme.sh with Dash

2019-10-15 Thread Alexander Kernozhitsky
gepardo added a comment.


  Thanks. Can you please merge it? I don't have a developer access to KDE repos.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24447: Fix compatibility of build_theme.sh with Dash

2019-10-15 Thread Carson Black
cblack accepted this revision.
cblack added a comment.


  LGTM 

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24447: Fix compatibility of build_theme.sh with Dash

2019-10-06 Thread Alexander Kernozhitsky
gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  The script build_sh didn't work with Dash necause of "[[". When running it, I 
got the following:
  
  $ ./build_theme.sh 
  Installing into /home/gepardo/.local/share/themes/Breeze
  ./build_theme.sh: 111: [[: not found
  cp: cannot create directory '': No such file or directory

TEST PLAN
  After changing "[[" to "[", it worked fine and installed the theme

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

AFFECTED FILES
  src/build_theme.sh

To: gepardo
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart