D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Bhushan Shah 
bshah added a comment.


  > Commited to 5.17, should I cherry pick the commit to master or merge the 
5.17 branch back into master?
  
  Generally you merge the branch back in master, but I've done it 
(metadata.desktop file of package also needed updating).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24451

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Jonah Brüchert 
jbbgameich added a comment.


  Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 
branch back into master?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mobile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24451

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Jonah Brüchert 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:91e6cf9694cd: metadata: Add form factors to make kcm 
appear on mobile again (authored by jbbgameich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24451?vs=67400=67403#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24451?vs=67400=67403

REVISION DETAIL
  https://phabricator.kde.org/D24451

AFFECTED FILES
  src/kcm/kcm_pulseaudio.desktop

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-06 Thread Bhushan Shah 
bshah accepted this revision.
bshah added a comment.


  Please commit to 5.17 as well.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mobile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24451

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-06 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Seems to be required to make the kcm visible in plasma-settings

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mobile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24451

AFFECTED FILES
  src/kcm/kcm_pulseaudio.desktop

To: jbbgameich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart