D24503: Integrate the normal keyboard layout switcher

[David Edmundson]

davidedmundson added a comment.


  > I'd say so. We can do it when we deprecate the SNI though, unless you 
really want it now. I've never done it so I'll have to research how it's done.
  
  I don't want it to get forgotten and us to do work in a rush when the release 
comes along.
  
  ---
  
  As for the other IM work, that was the state when I originally wanted to port 
this layout item (T5331 ) 2.5 years ago. 
Doing everything all at once isn't an approach that seems to be working. 
  Having the kimpanel on by default and dropping the SNI from the kded/kwin 
seems like it's a step that would be needed anyway, so this is work towards 
that end goal even if this specific plasmoid does end up getting replaced.
  
  From my POV, ship it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: mart, hein, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol added a comment.


  > Can that work be resumed/used?
  
  See D14796 . It seems like the original 
author is MIA. I rebased the patch, seems to work but adopting it will set us 
back as the ibus backend was never implemented.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: mart, hein, broulik, davidedmundson, plasma-devel, crossi, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D24503: Integrate the normal keyboard layout switcher

[Marco Martin]

mart added a comment.


  In D24503#545961 , @hein wrote:
  
  > For context though, in the GSoC the following work was done:
  >
  > - The keyboard layout KCM was rewritten in Qt Quick
  
  
  Can that work be resumed/used?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: mart, hein, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol added a comment.


  This got landed by arc together with another patch. I didn't mean to land it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f2e579f9b366: Integrate the normal keyboard layout 
switcher (authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24503?vs=67514&id=67901

REVISION DETAIL
  https://phabricator.kde.org/D24503

AFFECTED FILES
  applets/kimpanel/package/contents/ui/StatusIcon.qml
  applets/kimpanel/package/contents/ui/main.qml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: apol, #plasma
Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol added a comment.


  I don't claim to solve the whole problem, it's just a step forward.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24503: Integrate the normal keyboard layout switcher

[Eike Hein]

hein added a comment.


  It's a small part of the work Geon Park did in his GSoC project to refactor 
kimpanel and our input sources management in general, but in a more 
merge-friendly format.
  
  The former sadly never got any review attention because the patch was too 
big, so maybe this is the right way to make progress.
  
  For context though, in the GSoC the following work was done:
  
  - The keyboard layout KCM was rewritten in Qt Quick
  - It's based on a model that can contain both IMEs and keyboard layouts
  - The model can dynamically react to IME daemons coming and going and doing a 
sensible fallback
  - The implementation is shared between the KCM, kimpanel (which, like here, 
replaces the old SNI) and the kded module that on X11 provides the D-Bus API to 
manage layouts
  - That means global shortcuts like Next/Prev Keyboard Layout we have work 
over both IMEs and layouts
  - That means the OSD and the lock screen show the right thing and became 
IME-aware
  
  And a couple of other things. What wasn't done was touch KWin/Wayland (which 
in a Plasma/Wayland session provides the same D-Bus API kded provides on X11).
  
  So it's important to remember that this is the goal. With this patch Plasma 
would get better, but it doesn't address the whole problem (System Settings 
being useless for IMEs, the IME daemon making System Settings useless when 
running, two incompatible systems fighting each other, expert knowledge 
required to set things up in the first place, etc).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in layout.js:38
> Do we also need a plasma upgrade script if we remove the SNI from kded/kwin

I'd say so. We can do it when we deprecate the SNI though, unless you really 
want it now. I've never done it so I'll have to research how it's done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24503: Integrate the normal keyboard layout switcher

[Kai Uwe Broulik]

broulik added a comment.


  Do we need an update script to add this plasmoid to all existing setups?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24503: Integrate the normal keyboard layout switcher

[David Edmundson]

davidedmundson added a comment.


  Makes sense, there's a lot of red and it's about to lead to more.
  
  I like that.

INLINE COMMENTS

> main.qml:45-47
>  width: parent.width
>  height: parent.height
> +anchors.centerIn: parent

anchors.fill

> layout.js:38
> -
> -/* Next up is determining whether to add the Input Method Panel
> - * widget to the panel or not. This is done based on whether

Do we also need a plasma upgrade script if we remove the SNI from kded/kwin

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67514.
apol added a comment.


  Send a sensible font size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24503?vs=67513&id=67514

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24503

AFFECTED FILES
  applets/kimpanel/package/contents/ui/StatusIcon.qml
  applets/kimpanel/package/contents/ui/main.qml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67513.
apol added a comment.


  Remove unused function

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24503?vs=67512&id=67513

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24503

AFFECTED FILES
  applets/kimpanel/package/contents/ui/StatusIcon.qml
  applets/kimpanel/package/contents/ui/main.qml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This deprecates the SNI from KWin in favour of this plasmoid that will
  allow doing the same as well as managing the different IME tech we
  support.
  
  This also changes the default panel layout to include kimpanel since it
  will be useful in any language.
  
  Related to D12069  and D14796 


TEST PLAN
  I can switch between catalan and american keyboard, if ibus
  is running I can do the same but through ibus.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24503

AFFECTED FILES
  applets/kimpanel/package/contents/ui/StatusIcon.qml
  applets/kimpanel/package/contents/ui/main.qml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart