D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

kmaterka added a comment.


  In D24530#547085 , @ngraham wrote:
  
  > FWIW since you landed this on master rather than `Plasma/5.17`, it will 
only be in Plasma 5.18, not 5.17.1.
  >
  > At this point, if it's critical to go into 5.17.1, you should cherry-pick 
the commit onto the `Plasma/5.17` branch since landing it there and merging 
forward is no longer possible.
  
  
  It is not critical, it can wait for 5.18.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: ngraham, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Nathaniel Graham]

ngraham added a comment.


  FWIW since you landed this on master rather than `Plasma/5.17`, it will only 
be in Plasma 5.18, not 5.17.1.
  
  At this point, if it's critical to go into 5.17.1, you should cherry-pick the 
commit onto the `Plasma/5.17` branch since landing it there and merging forward 
is no longer possible.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: ngraham, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5e934611316b: [XembedSNIProxy] If available, always use 
32-bit color. (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24530?vs=67592=67890

REVISION DETAIL
  https://phabricator.kde.org/D24530

AFFECTED FILES
  xembed-sni-proxy/fdoselectionmanager.cpp
  xembed-sni-proxy/fdoselectionmanager.h

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[David Edmundson]

davidedmundson added a comment.


  You can merge now :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Laurent Montel]

mlaurent added a comment.


  Hi,
  You can't commit yet as nobody accepted this patch.
  Regards

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

kmaterka added a comment.


  I have Develop Account now. Is review finished or something more is needed? 
Can I push this change?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

kmaterka added a comment.


  D24514  is merged, this one should apply 
smoothly now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: davidedmundson, Plasma: Workspaces, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  If available, always use 32-bit color. We don't need Composite extension to 
handle transparency - all client windows are our children and transparency in 
handled in QML, inside the panel (so no need to composite real windows).
  
  BUG: 356937 

TEST PLAN
  Disable compositor, run:
  
  - pidgin (make sure pidgin-libnotify is NOT installed)
  - keepassx
  - xchat
  - liferea
  
  Before changes: black backgroud
  After changes: transparent background

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

AFFECTED FILES
  xembed-sni-proxy/fdoselectionmanager.cpp
  xembed-sni-proxy/fdoselectionmanager.h

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

kmaterka added a comment.


  Needs to be applied after D24514 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart