D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-29 Thread Roman Gilg 
romangg added a comment.


  See D25027 

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-22 Thread Kai Uwe Broulik 
broulik added a comment.


  So, what about this now? Or is there an auto scale patch anywhere?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  +1 for auto-zoom and making the screens bigger. Then we can remove the 
buttons that centers the view too.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-17 Thread Kai Uwe Broulik 
broulik added a comment.


  That could also work, however the view wastes a lot of space right now, the 
screens could be a lot bigger, if we were to auto-zoom.
  F7615211: Screenshot_20191017_153310.png 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-17 Thread Roman Gilg 
romangg added a comment.


  There was also the idea to drop the `Center View` button and instead resize 
the view whenever an output is dropped to a different position. I feel this 
would be also a more elegant solution for the issue trying to be solved here, 
if we agree that this would be in general a good idea. Do we? @ngraham: I mean 
I talked about this with you.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-17 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 68125.
broulik added a comment.


  - No magic numbers

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24688?vs=68025=68125

REVISION DETAIL
  https://phabricator.kde.org/D24688

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-16 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in Screen.qml:83
> Suggestions?

IMO magic numbers are probably okay here, but 20 is pretty similar to GridUnit 
so maybe just use multiples of that instead?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-16 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> Screen.qml:83
> +// Ensure a corner of a screen always stays visible
> +visibleBounds: Qt.rect(20, 20, screenView.width - 40, 
> screenView.height - 40)
> +}

magic numbers?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-16 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> mart wrote in Screen.qml:83
> magic numbers?

Suggestions?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

To: broulik, #plasma, #vdg, romangg
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D24688: [KCM] Disallow dropping screen outside of reachable area

2019-10-16 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, VDG, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In the old KCM it was annoying that you couldn't drag screens outside when 
arranging them. However, in the new KCM you can lose the screens outside 
visible boundaries and only get them back by clicking "Center View".
  This patch ensures that when *dropping* a screen, a corner of it stays 
visible so you can drag it back. Movement while dragging remains unrestricted.

TEST PLAN
  5.17?
  This is the furthest I can drag a screen out.
  F7605495: Screenshot_20191016_100650.png 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24688

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml

To: broulik, #plasma, #vdg, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart