D24732: Rewrite AppChooser dialog

2019-10-24 Thread Jan Grulich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:c85055441a22: Rewrite AppChooser dialog (authored by 
jgrulich).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68673&id=68730

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-24 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#552239 , @ngraham wrote:
  
  > There still isn't a border around the inner view. That's what I'm trying to 
get there. Otherwise it doesn't look like an inner view; it looks like a 
floating rectangle.
  
  
  Solved now. I used same border which is used in Kirigami components. I also 
added small rounding for the highlight, which I think makes it little more 
nicer.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-24 Thread Jan Grulich 
jgrulich updated this revision to Diff 68673.
jgrulich added a comment.


  - Add border around the view and use small radius around for item highlight

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68502&id=68673

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-23 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#552239 , @ngraham wrote:
  
  > There still isn't a border around the inner view. That's what I'm trying to 
get there. Otherwise it doesn't look like an inner view; it looks like a 
floating rectangle.
  
  
  Right, I don't really know what would be a proper way to implement this, just 
adding borders around the rectangle might be one solution, but I would rather 
use or make it work the way you suggested before.Does someone have an idea how 
to do that? @mart or @apol?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-22 Thread Nathaniel Graham 
ngraham added a reviewer: VDG.
ngraham added a comment.


  There still isn't a border around the inner view. That's what I'm trying to 
get there. Otherwise it doesn't look like an inner view; it looks like a 
floating rectangle.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham, #vdg
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-22 Thread Jan Grulich 
jgrulich added a comment.


  Updated screenshot:
  F7649124: Screenshot_20191022_161043.png 

  
  To be honest, I liked the result more when the "view" wasn't using a 
different background.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-22 Thread Jan Grulich 
jgrulich updated this revision to Diff 68502.
jgrulich added a comment.


  - Add Kirigami2 as a dependency

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68501&id=68502

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-22 Thread Jan Grulich 
jgrulich updated this revision to Diff 68501.
jgrulich added a comment.


  - Code improvements

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68382&id=68501

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-21 Thread Nathaniel Graham 
ngraham added a subscriber: mart.
ngraham added a comment.


  In D24732#551035 , @jgrulich wrote:
  
  > In D24732#550902 , @ngraham 
wrote:
  >
  > > So close! You don't need to create a `Rectangle` to give the ScrollView a 
white background; just set `Component.onCompleted: background.visible = true` 
on the scrollview itself. Here's an example of how it's done in the 
Notifications KCM: 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94
  >
  >
  > It doesn't seem to work in my case.
  
  
  That's odd. Any idea why, @mart or @apol?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: mart, GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra

D24732: Rewrite AppChooser dialog

2019-10-20 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#550902 , @ngraham wrote:
  
  > So close! You don't need to create a `Rectangle` to give the ScrollView a 
white background; just set `Component.onCompleted: background.visible = true` 
on the scrollview itself. Here's an example of how it's done in the 
Notifications KCM: 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94
  
  
  It doesn't seem to work in my case.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-20 Thread Nathaniel Graham 
ngraham added a comment.


  So close! You don't need to create a `Rectangle` to give the ScrollView a 
white background; just set `Component.onCompleted: background.visible = true` 
on the scrollview itself. Here's an example of how it's done in the 
Notifications KCM: 
https://cgit.kde.org/plasma-desktop.git/tree/kcms/notifications/package/contents/ui/SourcesPage.qml#n94

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-20 Thread Jan Grulich 
jgrulich updated this revision to Diff 68382.
jgrulich added a comment.


  - Improvements based on review comments

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68218&id=68382

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-18 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Aha, the old one was indeed still running! I can see the new one now.
  
  - My request to give the scrollview a frame and the background isn't 
implemented yet.
  - My request to use the pointing hand cursor when hovering over an app isn't 
implemented yet.
  - Long app names still get elided rather than becoming multi-line strings.

INLINE COMMENTS

> AppChooserDialog.qml:99
> +bottom: parent.bottom
> +horizontalCenter: parent.horizontalCenter
> +}

Set left and right anchors too so it takes up the full width

> AppChooserDialog.qml:103
> +opacity: visible
> +placeholderText: i18n("search...");
> +

Capitalize the S

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma, ngraham
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-18 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#549750 , @ngraham wrote:
  
  > On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried 
overriding that file with the one I just built from source (because it didn't 
seem to use the built-from-source one at 
`~/kde/usr/lib64/libexec/xdg-desktop-portal-kde`) but even then, I still get 
the old dialog in the Flatpak version of Dolphin. What am I doing wrong here?
  
  
  Did you kill the previous one? It might still be running and that's why it 
didn't pick the new dialog. You can also start it manually, just kill any 
xdg-desktop-portal-kde instance and run the one you want (from any location).  
It will even tell you it's already running when you use 
"QT_LOGGING_RULES='xdp*.debug=true'".

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-18 Thread Nathaniel Graham 
ngraham added a comment.


  On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried 
overriding that file with the one I just built from source (because it didn't 
seem to use the built-from-source one at 
`~/kde/usr/lib64/libexec/xdg-desktop-portal-kde`) but even then, I still get 
the old dialog in the Flatpak version of Dolphin. What am I doing wrong here?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-18 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#549249 , @ngraham wrote:
  
  > Finally, I would consider adding the "Other applications are available in 
Discover" text to the bottom, so it doesn't interrupt the dialog's flow.
  
  
  I'm not sure about that, because we already have the button and  the search 
bar at the botttom.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-18 Thread Jan Grulich 
jgrulich updated this revision to Diff 68218.
jgrulich added a comment.


  Address review comments

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68140&id=68218

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#549249 , @ngraham wrote:
  
  > Give the scrollview a frame and a white background or else apps look cut 
off and weird and there's a mysteriously hovering scroller: F7616694: 
Screenshot_20191017_111833.png 
  >
  > Also why are there duplicates in here?
  
  
  From the screenshot I can see you use the current version of the dialog. Make 
sure you installed it to the correct location, on my system (Fedora) it's 
installed to /usr/libexec/xdg-desktop-portal-kde.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  Give the scrollview a frame and a white background or else apps look cut off 
and weird and there's a mysteriously hovering scroller: F7616694: 
Screenshot_20191017_111833.png 
  
  Also why are there duplicates in here?
  
  Finally, I would consider adding the "Other applications are available in 
Discover" text to the bottom, so it doesn't interrupt the dialog's flow.

INLINE COMMENTS

> AppChooserDialog.qml:122
> +
> +MouseArea {
> +id: mouseArea

Change the cursor to the pointing hand cursor when hovering over something that 
will immediately perform an action when clicked

> AppChooserDialog.qml:140
> +
> +Label {
> +anchors {

Allow this label to become a multi-line string for apps that have long-ish 
names:
F7616689: Screenshot_20191017_111655.png 

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Björn Feber 
GB_2 added inline comments.

INLINE COMMENTS

> AppChooserDialog.qml:47
> +horizontalAlignment: Text.AlignHCenter
> +text: i18n("Select application to open %1. Other applications 
> are available in Discover.", fileName)
> +textFormat: Text.RichText

"Select an application to open %1. More applications are available in Discover."

> AppChooserDialog.qml:85
> +icon.name: "view-more-symbolic"
> +text: i18n("Show more")
> +

"Show More"

> AppChooserDialog.qml:118
> +color: highlightColor
> +radius: 5
> +visible: ApplicationDesktopFile == defaultApp

We don't really use rounded rectangles for highlights anywhere (except in the 
Plasma theme).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich added a comment.


  Use Dolphin from Flathub to open some file.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Nathaniel Graham 
ngraham added a comment.


  What's the best way to test this out?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 looks much better

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich added a comment.


  Is this better?
  
  F7615448: Screenshot_20191017_155608.png 


REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich updated this revision to Diff 68140.
jgrulich added a comment.


  Add text to the button rather then using tooltip

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68137&id=68140

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich added a comment.


  In D24732#548992 , @ognarb wrote:
  
  > I would add text on the button e.g "Show more", otherwise it's quite 
difficult to know how to show more apps
  
  
  There is a tooltip, but maybe showing text next to it might be better.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Carl Schwan 
ognarb added a comment.


  I would add text on the button e.g "Show more", otherwise it's quite 
difficult to know how to show more apps

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich added a comment.


  This is the initial state of the dialog, which presents only apps associated 
with given mimetype. Then if you click at the button below, it will show all 
the apps and provide a search bar.
  F7615342: Screenshot_20191017_154506.png 


REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24732

To: jgrulich, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich updated this revision to Diff 68137.
jgrulich added a comment.


  Do not duplicate desktop files

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24732?vs=68134&id=68137

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24732: Rewrite AppChooser dialog

2019-10-17 Thread Jan Grulich 
jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  The new version of dialog allows you to select any application
  if associated applications are not what users want. The dialog
  also now uses model and view, where the view is written in QML
  as QWidgets don't have anything like QGridView.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  new-app-dialog

REVISION DETAIL
  https://phabricator.kde.org/D24732

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/appchooserdialog.cpp
  src/appchooserdialog.h
  src/appchooserdialog.ui
  src/appchooserdialogitem.cpp
  src/appchooserdialogitem.h
  src/qml/AppChooserDialog.qml

To: jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart