D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  In D24767#552096 , @broulik wrote:
  
  > Doesn't this break the binding for `source`? My tray icons don't update 
anymore
  
  
  Fix in D24865 , sorry...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  In D24767#552096 , @broulik wrote:
  
  > Doesn't this break the binding for `source`? My tray icons don't update 
anymore
  
  
  Hmm, I will test that. It is possible :/ Definitely there is something wrong 
with PlasmaCore.IconItem.source binding. AttentionIcon was not shown when I did:
  
PlasmaCore.IconItem {
id: iconItem
source: status === PlasmaCore.Types.NeedsAttentionStatus ? 
(AttentionIcon ? AttentionIcon : AttentionIconName) : (Icon ? Icon : IconName)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Kai Uwe Broulik]

broulik added a comment.


  Doesn't this break the binding for `source`? My tray icons don't update 
anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:51964243ad40: [SystemTray] Support for AttentionIcon 
(authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24767?vs=68268&id=68277

REVISION DETAIL
  https://phabricator.kde.org/D24767

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka added a comment.


  As part of:
  
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24767

To: kmaterka, #plasma, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24767: [SystemTray] Support for AttentionIcon

[Konrad Materka]

kmaterka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Adding support for Attention Icon to StatusNotifier tray icons
  
  BUG: 341255

TEST PLAN
  As described in bug report, Konversation can be used for tests.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24767

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart