D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c21a8bd82ec2: Require and use the new NewStuffQuick 
Button component (authored by leinir).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24942?vs=68958&id=69032

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D24942#556062 , @ngraham wrote:
  
  > Thanks, that fixes the issue. This works quite well now.
  >
  > Would be nice to address the bugs I filed before 5.18 is released so it 
really gets polished up all nice and shiny. :)
  
  
  Thanks for the confirmation! :)
  
  Definitely would, i'm endeavouring to run through the issues quick as 
possible :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, that fixes the issue. This works quite well now.
  
  Would be nice to address the bugs I filed before 5.18 is released so it 
really gets polished up all nice and shiny. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

To: leinir, #plasma, #knewstuff, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 68958.
leinir added a comment.


  Together with the change in D25041  this 
makes the model reloading work
  (without that patch, it simply fails quietly as the signal forwarding
  fails). If wanted, we could also use the count property in the same
  diff to reintroduce the previous logic (which of course would then
  require that patch having been merged first)
  
  - Simplify the model reload logic a touch

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24942?vs=68742&id=68958

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir, #plasma, #knewstuff, #vdg, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Nathaniel Graham]

ngraham added a comment.


  Nice. However it doesn't seem to work for me. If I install a theme using the 
dialog, it doesn't show up in the Global Themes KCM. Could it because of a typo 
(`changedEntryes.count()`) ?
  
  I've filed a bunch of bug reports regarding polishing the dialog itself:
  
  - https://bugs.kde.org/show_bug.cgi?id=413433
  - https://bugs.kde.org/show_bug.cgi?id=413434
  - https://bugs.kde.org/show_bug.cgi?id=413435
  - https://bugs.kde.org/show_bug.cgi?id=413436
  - https://bugs.kde.org/show_bug.cgi?id=413437
  - https://bugs.kde.org/show_bug.cgi?id=413439
  - https://bugs.kde.org/show_bug.cgi?id=413440
  - https://bugs.kde.org/show_bug.cgi?id=413441

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24942

To: leinir, #plasma, #knewstuff, #vdg, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24942: Require and use the new NewStuffQuick Button component

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This removes the need for the custom hack for spawning a dialog,
  and is intended to function as a sample for how to implement this
  in other KCMs.
  
  Also use the big, pretty Preview mode (because super-visual content)
  
  This could be done wholesale for the entire bunch of KCMs, but i post
  this on its own in an attempt to gain feedback on a self contained
  example of how to do this porting step.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-newstuffquick-in-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24942

AFFECTED FILES
  CMakeLists.txt
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart