D25273: Enable selecting all installed color schemes in Cuttlefish

2020-01-27 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R118:2d8d17a7b4e6: Enable selecting all installed color 
schemes in Cuttlefish (authored by davidre).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=74358=74448

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2020-01-25 Thread David Redondo 
davidre updated this revision to Diff 74358.
davidre marked an inline comment as done.
davidre added a comment.


  Fix typo

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=74332=74358

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2020-01-25 Thread David Redondo 
davidre added a comment.


  In D25273#600583 , @ngraham wrote:
  
  > Bad combobox width strikes again 
(https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon:
  
  
  Bah we should fix it finally if possible
  
  > F7939162: Screenshot_20200124_204922.PNG 

  > 
  > Also, gross, there are duplicates
  
  See above. Something to fix in KColorSchemeManager to not load the same theme 
twice if it has the same name as another one. (As the Colors KCM does)

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2020-01-24 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Bad combobox width strikes again 
(https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon:
  
  F7939162: Screenshot_20200124_204922.PNG 

  
  Also, gross, there are duplicates

INLINE COMMENTS

> main.cpp:139
>  qmlRegisterAnonymousType("org.kde.plasma.sdk", 1);
> +qmlRegisterAonymousType("org.kde.plasma.sdk", 
> 1);
>  #endif

typo causes a build failure

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2020-01-24 Thread David Redondo 
davidre added a comment.


  Ping since system theme support is now in frameworks and  plasma master can 
depend on frameworks master

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2020-01-24 Thread David Redondo 
davidre updated this revision to Diff 74332.
davidre added a comment.


  - remove default color scheme, system theme support in kcolorschememanager, 
also display icons

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69667=74332

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D25273#561852 , @davidre wrote:
  
  > Since this directly uses KColorSchemeManager, do you also see duplicated 
entries in Kate's color scheme menu?
  
  
  Yep.
  
  In D25273#561875 , @davidre wrote:
  
  > I think I know what's happening. Do you have Breeze installed into the same 
prefix as cuttlefish in addition to system breeze? After doing so I also see 
the duplicate color. (The same happens in Kate)
  
  
  That's right.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo 
davidre added a comment.


  In D25273#561847 , @ngraham wrote:
  
  > Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 

  
  
  I think I know what's happening. Do you have Breeze installed into the same 
prefix as cuttlefish in addition to system breeze? After doing so I also see 
the duplicate color. (The same happens in Kate)

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo 
davidre updated this revision to Diff 69667.
davidre added a comment.


  Load initial color scheme name from the respective .colors file

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69639=69667

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-13 Thread David Redondo 
davidre added a comment.


  In D25273#561845 , @ngraham wrote:
  
  > Nice, it's good to get rid of so much boilerplate.
  >
  > However when I change the system's own color scheme from Breeze to anything 
else and start Cuttlefish, the app itself uses that color scheme as expected, 
but the combobox's text is blank: F7760159: Screenshot_20191112_221601.png 

  
  
  I see what's happening. I copied that code form Kate and it reads the current 
color scheme name from kdeglobals but there can be a difference between the 
stored name and the user visible name. Especially when it includes a space or 
hyphen. So it works correctly for Breeze or Oxygen but not Breeze Dark or 
Oxygen cold.
  
  In D25273#561847 , @ngraham wrote:
  
  > Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 

  
  
  Since this directly uses KColorSchemeManager, do you also see duplicated 
entries in Kate's color scheme menu?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread Nathaniel Graham 
ngraham added a comment.


  Also, the combobox's model appears to have duplicates for Breeze, Breeze 
Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for 
me: F7760168: Screenshot_20191112_221936.png 


REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread Nathaniel Graham 
ngraham added a comment.


  Nice, it's good to get rid of so much boilerplate.
  
  However when I change the system's own color scheme from Breeze to anything 
else and start Cuttlefish, the app itself uses that color scheme as expected, 
but the combobox's text is blank: F7760159: Screenshot_20191112_221601.png 


REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo 
davidre added inline comments.

INLINE COMMENTS

> main.cpp:130
> +engine.rootContext()->setContextProperty("colorSchemes", colorSchemes);
> +engine.load(QUrl::fromLocalFile(package.filePath("mainscript")));
> +

Moving the setting of the context properties before loading of the file fixes 
these being unavailable at the beginning. => Less errors on startup and we can 
select the the current color scheme on startup because the index isn't reset 
when the color scheme model becomes available.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo 
davidre updated this revision to Diff 69639.
davidre added a comment.


  Was a typo

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69637=69639

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo 
davidre planned changes to this revision.
davidre added a comment.


  I somehow broke it before uploading

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

2019-11-12 Thread David Redondo 
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  By using KColorSchemeManager we can enable viewing icons with all installed
  color schemes.

REPOSITORY
  R118 Plasma SDK

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart