D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Moved over to 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: justinzobel, bruns, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Justin Zobel]

justinzobel added a comment.


  Can we please move this to Gitlab as a draft MR, thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: justinzobel, bruns, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham added a comment.


  Here's a patch that does that: D25447 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: bruns, cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham added a comment.


  In D25280#565711 , @bruns wrote:
  
  > Agree with David/Thomas, first we need a "Suspend" button or similar.
  
  
  In fact there's already a bug report asking for this: 
https://bugs.kde.org/show_bug.cgi?id=374474
  
  I'll do that first, then we can revisit this patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: bruns, cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Stefan Brüns]

bruns added a comment.


  Agree with David/Thomas, first we need a "Suspend" button or similar.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: bruns, cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Tomaz Canabrava]

tcanabrava added a comment.


  I gree with david's questioning, sometimes I disable indexing when I'm about 
to do something heavy, to re-enable it later. I don't want to lose all my data.
  perhaps there should be a box `purge database data`  instead of purging on 
disable?

INLINE COMMENTS

> main.qml:43
> +text: i18n("Turning off file search will remove all existing 
> index data.");
> +
> +}

stray newline

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham added a reviewer: Baloo.
ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham updated this revision to Diff 69809.
ngraham added a comment.


  Improve string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25280?vs=69781&id=69809

BRANCH
  purge-index-when-disabling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25280

AFFECTED FILES
  kcms/baloo/kcm.cpp
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, tcanabrava, #plasma
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham updated this revision to Diff 69781.
ngraham added a comment.


  - Invoke first run logic when indexing is turned on again after previously 
being turned off
  - Show warning message when the user goes to turn it off, but before hitting 
"Apply"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25280?vs=69654&id=69781

BRANCH
  purge-index-when-disabling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25280

AFFECTED FILES
  kcms/baloo/kcm.cpp
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, tcanabrava, #plasma
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[David Edmundson]

davidedmundson resigned from this revision.
davidedmundson added a comment.


  In theory it's all just a cache of data elsewhere.
  
  The downside of this patch is that if a user temporarily disables the 
indexer, when it's re-enabled we're triggering an entire first scan reset of 
everything.
  
  If we did this patch, does the config value "first run" need resetting to 
true?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Christoph Feck]

cfeck added a comment.


  Shouldn't there be a warning message "delete yes/no?"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, davidedmundson
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[David Edmundson]

davidedmundson added a comment.


  Tags are stored as xattr, but indexed and cached in the baloo DB. The tags IO 
slave only searches the cache.
  
  I had a recollection that adding a tag in dolphin/whatever forced a basic 
index of that file. However, I can't find any reference to that anymore. My 
knowledge of Baloo comes from late KDE4 days. It seems I was talking nonsense.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham added a comment.


  I thought tags were stored in extended attributes on the tagged files, not in 
the database. And can you clarify regarding what's stored in the database for 
activities?
  
  I do see code calling `baloo_file_cleaner` but that executable does not seem 
to exist anymore. Maybe that's why this isn't working?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Baloo covers tags and activities, regardless of indexer. Wiping the index 
does not make sense.
  
  What you want to achieve is what baloo_file_cleaner does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: tcanabrava, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The only reason why a user would want to entirely disable file indexing is 
because they
  don't want their files indexed. This implies that if their files are already 
indexed,
  they would like the index deleted. Ergo, disabling indexing in the KCM should 
delete
  the index too.
  
  This patch does that. The `balooctl` command-line tool offers more granular 
options for
  disabling without deleting the index, but those should be considered expert 
options for
  power users who know what they're doing. For users using the KCM, deleting 
the index
  after disabling indexing makes the most sense.
  
  BUG: 414077
  FIXED-IN: 5.18.0

TEST PLAN
  1. Run `balooctl monitor`
  2. Disable indexing in the KCM
  3. See that indexing has been turned off and the database deleted
  4. Re-enable indexing in the KCM
  5. See that files are being indexed as with a first run.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  purge-index-when-disabling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25280

AFFECTED FILES
  kcms/baloo/kcm.cpp

To: ngraham, tcanabrava, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart