D25509: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:c96809b1dac2: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25509?vs=70265=70385 REVISION DETAIL https://phabricator.kde.org/D25509 AFFECTED FILES applets/weather/package/contents/ui/config/ConfigWeatherStation.qml applets/weather/package/contents/ui/config/WeatherStationPicker.qml applets/weather/package/contents/ui/config/WeatherStationPickerDialog.qml To: ngraham, spstarr, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25509: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components
spstarr added a comment. For the applet side, I didn't rewrite this, the original applet was non-QtQuick even, but even so, this looks sane to me. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25509 To: ngraham, spstarr, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25509: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components
ngraham created this revision. ngraham added reviewers: spstarr, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Everything is ported to QQC2 except for the TableView since there is no direct analogue in QQC2. The correct porting path is a ScrollView+ListView, but I can't do this right now since the search/weather station selection functionality is currently broken for me, making it impossible to test changes to the table. TEST PLAN Everything that was working before still works now REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25509 AFFECTED FILES applets/weather/package/contents/ui/config/ConfigWeatherStation.qml applets/weather/package/contents/ui/config/WeatherStationPicker.qml applets/weather/package/contents/ui/config/WeatherStationPickerDialog.qml To: ngraham, spstarr, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
