D25612: Simplify load of locale variables
This revision was automatically updated to reflect the committed changes. Closed by commit R120:26284d73cf94: Simplify load of locale variables (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70568&id=70573 REVISION DETAIL https://phabricator.kde.org/D25612 AFFECTED FILES kcms/translations/translations.cpp kcms/translations/writeexports.h startkde/startplasma.cpp To: apol, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25612: Simplify load of locale variables
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Lovely. There's a writeexports.h in p-d to kill too. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 To: apol, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25612: Simplify load of locale variables
apol updated this revision to Diff 70567. apol added a comment. Address david comment, merge all of the LANG things REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70555&id=70567 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 AFFECTED FILES kcms/translations/translations.cpp kcms/translations/writeexports.h startkde/startplasma.cpp To: apol, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25612: Simplify load of locale variables
apol updated this revision to Diff 70568. apol added a comment. Remember to sync REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70567&id=70568 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 AFFECTED FILES kcms/translations/translations.cpp kcms/translations/writeexports.h startkde/startplasma.cpp To: apol, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25612: Simplify load of locale variables
davidedmundson added a comment.
+1
INLINE COMMENTS
> startplasma.cpp:143
> if (!QFile::exists(localerc)) {
> QFile f(localerc);
> f.open(QFile::WriteOnly);
This may as well be merged if we're going to open the config next anyway
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25612
To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25612: Simplify load of locale variables
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Load l10n values using kconfig instead of sourcing a generated shell script from the kcm. TEST PLAN Builds, starts properly REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 AFFECTED FILES kcms/translations/translations.cpp kcms/translations/writeexports.h startkde/startplasma.cpp To: apol, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
