D25618: Account for a mnemonic label to go back to ""

2019-12-01 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e649887194f5: Account for a mnemonic label to go back to 
"" (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25618?vs=70587&id=70685

REVISION DETAIL
  https://phabricator.kde.org/D25618

AFFECTED FILES
  src/mnemonicattached.cpp

To: apol, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25618: Account for a mnemonic label to go back to ""

2019-11-29 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We are discarding the value if there's no weights which meant that when
  setting a button to "", the text provided by mnemonicLabel wouldn't update.
  This patch changes it so it only skips the weights computation if there's no
  text.

TEST PLAN
  Tested with patch that removes the text of some buttons when the
  screen is smaller on Discover.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25618

AFFECTED FILES
  src/mnemonicattached.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein