D25740: Add item spacing to size hint

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:74285aea999c: Add item spacing to size hint (authored by 
broulik).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25740?vs=70903&id=71189

REVISION DETAIL
  https://phabricator.kde.org/D25740

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, ndavis, hpereiradacosta
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25740: Add item spacing to size hint

[Nathaniel Graham]

ngraham added a comment.


  5.17 I'd say.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25740

To: broulik, ndavis, hpereiradacosta
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25740: Add item spacing to size hint

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: ndavis, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is what Adwaita Qt does [1] and it fixes the popup text being elided in 
Krita's filter popup with D25739 
  
  [1] 
https://github.com/FedoraQt/adwaita-qt/blob/master/style/adwaitastyle.cpp#L2856

TEST PLAN
  5.17?
  
  - Other comboboxes look unchanged because iirc it only uses that size hint 
for the popup contents in SH_ComboBoxPopup mode, not in the default case we 
have in Breeze usually
  
  Before
  F7798929: Screenshot_20191204_145032.png 

  After
  F7798925: Screenshot_20191204_144508.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25740

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, ndavis, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart