D25792: Add notifiers to workspace options kcfg

2019-12-10 Thread Cyril Rossi
crossi added a comment.


  Thanks  @davidedmundson for spotting this regression.
  
  Actually,  only AnimationDurationFactor should notify.
  
  From D25586 
  See kcms/workspaceoptions/workspaceoptions.cpp line 221.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25792

To: davidedmundson, ervin
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25792: Add notifiers to workspace options kcfg

2019-12-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8b00bcb9bc09: Add notifiers to workspace options kcfg 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25792?vs=71030&id=71155

REVISION DETAIL
  https://phabricator.kde.org/D25792

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: davidedmundson, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25792: Add notifiers to workspace options kcfg

2019-12-06 Thread David Edmundson
davidedmundson added a comment.


  Linked revision is needed to have it work properly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25792

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25792: Add notifiers to workspace options kcfg

2019-12-06 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  A write flag got lost in the KCFG port. This adds it back.

TEST PLAN
  dragged slider, kwin animation speed reloaded

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25792

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart