D25889: Polish the reviews UI and presentation
This revision was automatically updated to reflect the committed changes. Closed by commit R134:f41f25e895a9: Polish the reviews UI and presentation (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72758=72759 REVISION DETAIL https://phabricator.kde.org/D25889 AFFECTED FILES discover/qml/ReviewDelegate.qml discover/qml/ReviewsPage.qml To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25889: Polish the reviews UI and presentation
ngraham updated this revision to Diff 72758. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72336=72758 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL https://phabricator.kde.org/D25889 AFFECTED FILES discover/qml/ReviewDelegate.qml discover/qml/ReviewsPage.qml To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25889: Polish the reviews UI and presentation
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> ReviewDelegate.qml:188
> +checkable: true
> +checked: {
> +switch(usefulChoice) {
`checked: usefulChoice === ReviewsModel.No`
REPOSITORY
R134 Discover Software Store
BRANCH
polish-review-reviewing (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25889
To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25889: Polish the reviews UI and presentation
ngraham added a comment. I'll do the change to show the top positive and top negative reviews on the app page in a separate patch once this lands. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
