D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:35e8cb70c0c0: [Notifications KCM] Add KeySequenceItem for 
do not disturb shortcut (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26018?vs=71599=71787#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26018?vs=71599=71787

REVISION DETAIL
  https://phabricator.kde.org/D26018

AFFECTED FILES
  kcms/notifications/CMakeLists.txt
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  As discussed in chat:
  
i18nc("Turn do not disturb mode on/off with keyboard shortcut", "Toggle 
with:")

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26018

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[David Edmundson]

davidedmundson added a comment.


  That's accepting purely code-wise. 
  Please make sure the text is approved by VDG people before pushing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26018

To: broulik, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[Nathaniel Graham]

ngraham added a comment.


  +1 on adding this, for sure. I think it's nice when a feature's shortcut is 
exposed like this.

INLINE COMMENTS

> main.qml:100
> +QtControls.Label {
> +text: i18n("Keyboard shortcut:")
> +}

Maybe "Toggle with:"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26018

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  Not a huge fan of the code duplication there..
  
  Needs D26013  and D26016 
 to fully work
  F7819575: Screenshot_20191215_143457.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26018

AFFECTED FILES
  kcms/notifications/CMakeLists.txt
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart