D26056: [dataengine/geolocalisation] clean debug traces

2019-12-16 Thread Méven Car
meven added a comment.


  In D26056#578988 , @davidedmundson 
wrote:
  
  > if we're going to fix qDebug, lets fix the qDebug and move to categorized 
logging
  >
  >   // qDebug() << "gpsd not found";
  >   
  >
  > seems like an important warning
  
  
  I thought we might want to add a proper logging setup here.
  Did not take the time to do it properly.
  Probably will.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26056

To: meven, apol, #plasma, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26056: [dataengine/geolocalisation] clean debug traces

2019-12-16 Thread David Edmundson
davidedmundson added a comment.


  if we're going to fix qDebug, lets fix the qDebug and move to categorized 
logging
  
// qDebug() << "gpsd not found";
  
  seems like an important warning

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26056

To: meven, apol, #plasma, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26056: [dataengine/geolocalisation] clean debug traces

2019-12-16 Thread Méven Car
meven created this revision.
meven added reviewers: apol, Plasma, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26056

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: meven, apol, #plasma, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart