D26147: Kickoff computer tab : don't display filepath for places in description

2020-01-02 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:861e465951a0: Kickoff computer tab : dont display 
filepath for places in description (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26147?vs=72041=72652

REVISION DETAIL
  https://phabricator.kde.org/D26147

AFFECTED FILES
  applets/kicker/plugin/computermodel.cpp

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2020-01-02 Thread Méven Car 
meven added a comment.


  ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26147

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-28 Thread Méven Car 
meven added a comment.


  ping @hein

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26147

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-23 Thread Méven Car 
meven updated this revision to Diff 72041.
meven added a comment.


  Use default fallthrough

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26147?vs=71962=72041

BRANCH
  arcpatch-D26147

REVISION DETAIL
  https://phabricator.kde.org/D26147

AFFECTED FILES
  applets/kicker/plugin/computermodel.cpp

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-22 Thread Eike Hein 
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  The `return QString()` shouldn't be necessary if we just fall through to the 
final return.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26147

To: meven, ngraham, #plasma, #vdg, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-21 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much clearer.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26147

To: meven, ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26147: Kickoff computer tab : don't display filepath for places in description

2019-12-21 Thread Méven Car 
meven created this revision.
meven added reviewers: ngraham, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The path of places is not very informative to users
  Follow the path of D26121 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26147

AFFECTED FILES
  applets/kicker/plugin/computermodel.cpp

To: meven, ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart