D26200: Add shortcut for closing pages

[Nathaniel Graham]

ngraham added a comment.


  In D26200#589355 , @mart wrote:
  
  > hmm, not sure about it.
  >  it would probably be ok for most of the cases, but i'm pretty sure it may 
break some existing app.
  >  an app may want at least two pages always loaded for instance (if uses one 
for sidebar, one for main content)
  
  
  We could handle that by having the keystroke only get passed to the page with 
implicit focus, right?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D26200: Add shortcut for closing pages

[Marco Martin]

mart added a comment.


  hmm, not sure about it.
  it would probably be ok for most of the cases, but i'm pretty sure it may 
break some existing app.
  an app may want at least two pages always loaded for instance (if uses one 
for sidebar, one for main content)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D26200: Add shortcut for closing pages

[Nathaniel Graham]

ngraham added a comment.


  Maybe, but I think there is some value to having this handled by the toolkit 
to ensure behavioral consistency across apps.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D26200: Add shortcut for closing pages

[Aleix Pol Gonzalez]

apol added a comment.


  Shouldn't the application control whether its pages get closed and under 
which condition it happens?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D26200: Add shortcut for closing pages

[Nathaniel Graham]

ngraham added a comment.


  Hmm, does not work for me with Discover.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26200: Add shortcut for closing pages

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Kirigami, mart, ngraham.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The lack of standard way to close a page has always bothered me, particularly 
on the desktop. On mobile this is less of an issue since there is always only 
one page visible. Discover and Calindori have implemented Esc as shortcut for 
closing a page already.

TEST PLAN
  Closed some pages in plasma-phonebook

REPOSITORY
  R169 Kirigami

BRANCH
  close

REVISION DETAIL
  https://phabricator.kde.org/D26200

AFFECTED FILES
  src/controls/ApplicationWindow.qml

To: nicolasfella, #kirigami, mart, ngraham
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein