D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen
ndavis updated this revision to Diff 72277. ndavis added a comment. - Change newFrameRadius to newPenWidthFrameRadius This name doesn't sound very good, but at least it's more descriptive. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26225?vs=72185=72277 BRANCH replace-hardcoded-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26225 AFFECTED FILES kstyle/breeze.h kstyle/breezehelper.cpp kstyle/breezehelper.h To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen
hpereiradacosta added inline comments.
INLINE COMMENTS
> breezehelper.h:318
> +//* frame radius with new pen width
> +constexpr qreal newFrameRadius ( const qreal oldRadius, const int
> penWidth ) const
> +{ return qMax( oldRadius - (0.5 * penWidth), 0.0 ); }
Would need a new function name than "newFrameRadius", that makes it clear when
this should be used on not the other.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D26225
To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen
ndavis updated this revision to Diff 72185. ndavis added a comment. Add default value to frameRadius penWidth REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26225?vs=72184=72185 BRANCH replace-hardcoded-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26225 AFFECTED FILES kstyle/breeze.h kstyle/breezehelper.cpp kstyle/breezehelper.h To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen
ndavis created this revision. ndavis added reviewers: Breeze, Plasma, hpereiradacosta, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This patch reduces the amount of duplicate code and makes every part of the helper functions use the correct frame radius. REPOSITORY R31 Breeze BRANCH replace-hardcoded-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26225 AFFECTED FILES kstyle/breeze.h kstyle/breezehelper.cpp kstyle/breezehelper.h To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
