D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

2020-01-07 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin 
configuration changes (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26445?vs=72830=72957

REVISION DETAIL
  https://phabricator.kde.org/D26445

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

2020-01-05 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Connect `configCommitted` to ensure "Apply" gets enabled when you change any 
of the runner plugin settings.
  Also, clean up the other connect.

TEST PLAN
  - Connecting to `dirty` insted of `markAsDirty` so it can go into 5.17
  
  - Opened KCM, opened dictionary runner settings, changed keyword, "Apply" not 
got enabled as expected

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26445

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart