D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-21 Thread Vlad Zahorodnii 
This revision was automatically updated to reflect the committed changes.
Closed by commit R130:8b0244949229: [windowsystem] Provide a KWindowShadow 
implementation (authored by zzag).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=74059=74061

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-21 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 74059.
zzag added a comment.


  Update

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=74057=74059

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-21 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 74057.
zzag added a comment.


  Use QWindow::requestUpdate()

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=73729=74057

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-21 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  One minor change, otherwise it's all good.

INLINE COMMENTS

> windowshadow.cpp:99
> +shadowManager->removeShadow(surface);
> +surface->commit(KWayland::Client::Surface::CommitFlag::None);
> +shadow = nullptr;

Lets avoid this.

Firstly it messes with Qt. We're doing this potentially during platform window 
initialisation, we're potentially committing before it's set some super 
important properties that we need set on the first commit.

Secondly, we want it atomic with when the window updates (to a new theme or 
whatever) anyway.

window->requestUpdate(); would be a compromise, it'll make Qt do a commit at 
the next available time.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26458

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-16 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 73729.
zzag added a comment.


  Adjust to recent changes in KWindowShadow

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=73381=73729

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-13 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 73381.
zzag added a comment.


  Update.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=73380=73381

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-13 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 73380.
zzag added a comment.


  Fix a typo

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=73350=73380

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-12 Thread Vlad Zahorodnii 
zzag updated this revision to Diff 73350.
zzag added a comment.


  Track Shadow object

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26458?vs=72863=73350

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-06 Thread Vlad Zahorodnii 
zzag added a comment.


  This patch depends on D26457 .

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26458

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26458: [windowsystem] Provide a KWindowShadow implementation

2020-01-06 Thread Vlad Zahorodnii 
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26458

AFFECTED FILES
  src/windowsystem/CMakeLists.txt
  src/windowsystem/plugin.cpp
  src/windowsystem/plugin.h
  src/windowsystem/waylandintegration.cpp
  src/windowsystem/waylandintegration.h
  src/windowsystem/windowshadow.cpp
  src/windowsystem/windowshadow.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart