D26516: [Icon Item] Check URL validity and scheme

2020-01-13 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c765c990: [Icon Item] Check URL validity and scheme 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26516?vs=73038&id=73393

REVISION DETAIL
  https://phabricator.kde.org/D26516

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26516: [Icon Item] Check URL validity and scheme

2020-01-08 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Creating a `KFileItemList` with a `KFileItem` with a URL that doesn't have a 
scheme triggers an assert in `KFileItemListProperties`.
  It doesn't really make sense to have anyway.

TEST PLAN
  - Created an icon item with a desktop file with a `URL=foo`, no longer quit 
plasmashell when right clicking.
  
  Instead, the menu is empty now. Open with actions for proper files still work

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26516

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart