D26726: [Breeze Cursors] Add some more cursor names

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Our documentation can be found at:
  
  - https://community.kde.org/Get_Involved/development (setting up a 
development environment)
  - https://community.kde.org/Infrastructure/Phabricator (submitting the patch)
  
  If you run into trouble, feel free to ask for help in the #kde-devel 
Matrix/Freenode IRC room, or send an email to kde-de...@kde.org.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Guilherme Silva]

guilhermesilva added a comment.


  Alright, I'll try :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Nathaniel Graham]

ngraham added a comment.


  In D26726#610446 , @guilhermesilva 
wrote:
  
  > Hello,
  >
  > I'm the person the reported this issue 
 to the Chromium 
team. The fix they made will probably land only on Chromium 81 or later, but a 
lot of Electron apps will still rely on older versions of Chromium for a long 
time, where this missing cursors issue will still be present, unless they 
upgrade to Plasma 5.18.
  >
  > Speaking of which, I just upgraded to Plasma 5.18 myself, and it looks 
incredible, by the way. And this fix of yours is already present there too, 
which is great. However, I believe you unintentionally missed two CSS cursors: 
`grab`, and `grabbing`, which should be linked to `openhand` and `closedhand`, 
respectively. The rest of cursors are fine and can be tested here:
  >
  > http://elektronotdienst-nuernberg.de/bugs/cursor.html
  >
  > So, it'd be great if you added those too.
  >
  > Thanks!
  
  
  Great, I'm glad you're happy with it!
  
  As you can see here, the change is pretty simple. Would you like to try your 
hand at submitting a patch to add the two missing cursors, modeled on this one?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Guilherme Silva]

guilhermesilva added a comment.


  Hello,
  
  I'm the person the reported this issue 
 to the Chromium 
team. The fix they made will probably land only on Chromium 81 or later, but a 
lot of Electron apps will still rely on older versions of Chromium for a long 
time, where this missing cursors issue will still be present, unless they 
upgrade to Plasma 5.18.
  
  Speaking of which, I just upgraded to Plasma 5.18 myself, and it looks 
incredible, by the way. And this fix of yours is already present there too, 
which is great. However, I believe you unintentionally missed two CSS cursors: 
`grab`, and `grabbing`, which should be linked to `openhand` and `closedhand`, 
respectively. The rest of cursors are fine and can be tested here:
  
  http://elektronotdienst-nuernberg.de/bugs/cursor.html
  
  So, it'd be great if you added those too.
  
  Thanks!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: guilhermesilva, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:419274f46a67: [Breeze Cursors] Add some more cursor names 
(authored by broulik).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26726?vs=73760&id=74076

REVISION DETAIL
  https://phabricator.kde.org/D26726

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/ew-resize
  cursors/Breeze/Breeze/cursors/nesw-resize
  cursors/Breeze/Breeze/cursors/ns-resize
  cursors/Breeze/Breeze/cursors/nwse-resize
  cursors/Breeze/src/cursorList
  cursors/Breeze_Snow/Breeze_Snow/cursors/ew-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/nesw-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/ns-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/nwse-resize
  cursors/Breeze_Snow/src/cursorList

To: broulik, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[David Edmundson]

davidedmundson added a comment.


  Semi relevant: https://bugs.kde.org/show_bug.cgi?id=395247

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Kai Uwe Broulik]

broulik added a comment.


  > even though they're still "up for discussion."
  
  Yeah, and then I looked at the date ;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I suppose it doesn't hurt anything to add these even though they're still "up 
for discussion."

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26726: [Breeze Cursors] Add some more cursor names

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They are "up for discussion" [1] but seem to be used by e.g. Chrome.
  
  [1] https://www.freedesktop.org/wiki/Specifications/cursor-spec/

TEST PLAN
  Juts a bunch of symlinks, so 5.18
  Not sure where that `cursorList` file is being used (I also added some others 
that weren't added to this file in eb3498d9a797e3e21f0e722ecc0c9507c6f1b8ea 

  
  Now works
  F7888108: Screenshot_20200117_134406.PNG 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/ew-resize
  cursors/Breeze/Breeze/cursors/nesw-resize
  cursors/Breeze/Breeze/cursors/ns-resize
  cursors/Breeze/Breeze/cursors/nwse-resize
  cursors/Breeze/src/cursorList
  cursors/Breeze_Snow/Breeze_Snow/cursors/ew-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/nesw-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/ns-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/nwse-resize
  cursors/Breeze_Snow/src/cursorList

To: broulik, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart