D26803: [Notifications] Send reply text as targeted signal
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5369cf775c4b: [Notifications] Send reply text as targeted signal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26803?vs=74006=74009 REVISION DETAIL https://phabricator.kde.org/D26803 AFFECTED FILES libnotificationmanager/notification.cpp libnotificationmanager/notification.h libnotificationmanager/notification_p.h libnotificationmanager/notificationsmodel.cpp libnotificationmanager/server.cpp libnotificationmanager/server.h libnotificationmanager/server_p.cpp libnotificationmanager/server_p.h To: broulik, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26803: [Notifications] Send reply text as targeted signal
broulik updated this revision to Diff 74006. broulik added a comment. - No fallback, `createTargetedSignal` without a service seems to behave like the non-targeted version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26803?vs=73999=74006 REVISION DETAIL https://phabricator.kde.org/D26803 AFFECTED FILES libnotificationmanager/notification.cpp libnotificationmanager/notification.h libnotificationmanager/notification_p.h libnotificationmanager/notificationsmodel.cpp libnotificationmanager/server.cpp libnotificationmanager/server.h libnotificationmanager/server_p.cpp libnotificationmanager/server_p.h To: broulik, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26803: [Notifications] Send reply text as targeted signal
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids waking up non-interested parties. TEST PLAN 5.18 while it is an API change, it was only released in the Beta yet - Tried with Telgram patch, reply text field still worked REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26803 AFFECTED FILES libnotificationmanager/notification.cpp libnotificationmanager/notification.h libnotificationmanager/notification_p.h libnotificationmanager/notificationsmodel.cpp libnotificationmanager/server.cpp libnotificationmanager/server.h libnotificationmanager/server_p.cpp libnotificationmanager/server_p.h To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
