D26847: Hide irrevelevant default button, code clean and future proofing

[Méven Car]

meven added a comment.


  In D26847#600133 , @rikmills wrote:
  
  > Fails to build:
  >
  > 
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console
  >
  > 00:42:51 /workspace/build/src/usermanager.cpp: In constructor 
‘UserManager::UserManager(QWidget*, const QVariantList&)’:
  >  00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching 
function for call to ‘UserManager::connect(AccountInfo*&, void 
(AccountInfo::*)(bool), UserManager*, )’
  >  00:42:51  connect(m_widget, ::changed, this, 
::changed);
  >  00:42:51   
^
  
  
  Thanks @rikmills
  
  I don't get why it does not compile.
  I don't reproduce locally :/
  
  Tentative fix : https://phabricator.kde.org/D26893

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26847

To: meven, ngraham, #plasma
Cc: rikmills, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26847: Hide irrevelevant default button, code clean and future proofing

[Rik Mills]

rikmills added a comment.


  Fails to build:
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console
  
  00:42:51 /workspace/build/src/usermanager.cpp: In constructor 
‘UserManager::UserManager(QWidget*, const QVariantList&)’:
  00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching 
function for call to ‘UserManager::connect(AccountInfo*&, void 
(AccountInfo::*)(bool), UserManager*, )’
  00:42:51  connect(m_widget, ::changed, this, 
::changed);
  00:42:51  
 ^

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26847

To: meven, ngraham, #plasma
Cc: rikmills, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26847: Hide irrevelevant default button, code clean and future proofing

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:0f161b032e58: Hide irrevelevant default button, code 
clean and future proofing (authored by meven).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26847?vs=74160=74171

REVISION DETAIL
  https://phabricator.kde.org/D26847

AFFECTED FILES
  src/accountinfo.cpp
  src/usermanager.cpp

To: meven, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26847: Hide irrevelevant default button, code clean and future proofing

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R128 User Manager

BRANCH
  clean2

REVISION DETAIL
  https://phabricator.kde.org/D26847

AFFECTED FILES
  src/accountinfo.cpp
  src/usermanager.cpp

To: meven, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart