D26896: Kill the KinfoCenter binary

2020-01-28 Thread Johnny Jazeix 
jjazeix added inline comments.

INLINE COMMENTS

> CMakeLists.txt:85
> -configure_file(config-project-version.h.cmake 
> ${CMAKE_CURRENT_BINARY_DIR}/config-project-version.h)
> -configure_file(config-X11.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-X11.h)
>  include_directories(${CMAKE_CURRENT_BINARY_DIR})

Removing this file is breaking the compilation: 
https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/

  05:48:56  In file included from 
/usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 
FreeBSDQt5.13/Modules/base/os_current.cpp:24:
  05:48:56  /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 
FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' 
file not found
  05:48:56  #include 
  05:48:56   ^~

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma, davidedmundson
Cc: jjazeix, ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-28 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:24f4c6f97875: Kill the KinfoCenter binary (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26896?vs=74434&id=74493#toc

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26896?vs=74434&id=74493

REVISION DETAIL
  https://phabricator.kde.org/D26896

AFFECTED FILES
  CMakeLists.txt
  Categories/CMakeLists.txt
  Categories/basicinformation.desktop
  Categories/detailedinformation.desktop
  Categories/deviceinfocategory.desktop
  Categories/graphicalinfocategory.desktop
  Categories/kinfocentercategory.desktop
  Categories/networkinfocategory.desktop
  Modules/about-distro/src/about-distro.desktop
  Modules/energy/kcm_energyinfo.desktop
  Modules/fileindexermonitor/kcm_fileindexermonitor.desktop
  Modules/memory/kcm_memory.desktop
  ToolTips/tooltipmanager.cpp
  ToolTips/tooltipmanager.h
  config-X11.h.cmake
  config-project-version.h.cmake
  infocenter.cpp
  infocenter.h
  infokcmmodel.cpp
  infokcmmodel.h
  infokcmproxymodel.cpp
  infokcmproxymodel.h
  kcmcategoryitem.cpp
  kcmcategoryitem.h
  kcmcontainer.cpp
  kcmcontainer.h
  kcmtreeitem.cpp
  kcmtreeitem.h
  kinfocenterui.rc
  main.cpp
  main.h
  sidepanel.cpp
  sidepanel.h

To: mart, #plasma, davidedmundson
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-28 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:106
> +
> +ADD_CUSTOM_TARGET(kinfocenter_link ALL
> +  COMMAND ${CMAKE_COMMAND} -E create_symlink 
> ${KDE_INSTALL_FULL_BINDIR}/systemsettings5 
> ${CMAKE_CURRENT_BINARY_DIR}/kinfocenter)

comments for future devs explaining the situation would be useful

REPOSITORY
  R102 KInfoCenter

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma, davidedmundson
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-27 Thread Marco Martin 
mart updated this revision to Diff 74434.
mart added a comment.


  - back to kinfocenter bin name

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26896?vs=74433&id=74434

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26896

AFFECTED FILES
  CMakeLists.txt
  Categories/CMakeLists.txt
  Categories/basicinformation.desktop
  Categories/detailedinformation.desktop
  Categories/deviceinfocategory.desktop
  Categories/graphicalinfocategory.desktop
  Categories/kinfocentercategory.desktop
  Categories/networkinfocategory.desktop
  Modules/about-distro/src/about-distro.desktop
  Modules/energy/kcm_energyinfo.desktop
  Modules/fileindexermonitor/kcm_fileindexermonitor.desktop
  Modules/memory/kcm_memory.desktop
  ToolTips/tooltipmanager.cpp
  ToolTips/tooltipmanager.h
  config-X11.h.cmake
  config-project-version.h.cmake
  infocenter.cpp
  infocenter.h
  infokcmmodel.cpp
  infokcmmodel.h
  infokcmproxymodel.cpp
  infokcmproxymodel.h
  kcmcategoryitem.cpp
  kcmcategoryitem.h
  kcmcontainer.cpp
  kcmcontainer.h
  kcmtreeitem.cpp
  kcmtreeitem.h
  kinfocenterui.rc
  main.cpp
  main.h
  sidepanel.cpp
  sidepanel.h

To: mart, #plasma
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-27 Thread Marco Martin 
mart updated this revision to Diff 74433.
mart added a comment.


  - link kinfocenter to systemsettings5

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26896?vs=74308&id=74433

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26896

AFFECTED FILES
  CMakeLists.txt
  Categories/CMakeLists.txt
  Categories/basicinformation.desktop
  Categories/detailedinformation.desktop
  Categories/deviceinfocategory.desktop
  Categories/graphicalinfocategory.desktop
  Categories/kinfocentercategory.desktop
  Categories/networkinfocategory.desktop
  Modules/about-distro/src/about-distro.desktop
  Modules/energy/kcm_energyinfo.desktop
  Modules/fileindexermonitor/kcm_fileindexermonitor.desktop
  Modules/memory/kcm_memory.desktop
  ToolTips/tooltipmanager.cpp
  ToolTips/tooltipmanager.h
  config-X11.h.cmake
  config-project-version.h.cmake
  infocenter.cpp
  infocenter.h
  infokcmmodel.cpp
  infokcmmodel.h
  infokcmproxymodel.cpp
  infokcmproxymodel.h
  kcmcategoryitem.cpp
  kcmcategoryitem.h
  kcmcontainer.cpp
  kcmcontainer.h
  kcmtreeitem.cpp
  kcmtreeitem.h
  kinfocenterui.rc
  main.cpp
  main.h
  org.kde.kinfocenter.desktop
  sidepanel.cpp
  sidepanel.h

To: mart, #plasma
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-24 Thread Nathaniel Graham 
ngraham added a comment.


  In D26896#600258 , @broulik wrote:
  
  > Would it make sense to keep a `kinfocenter` script that just launchers 
`systemsettings5 -i` for compat?
  >  Does it still show up if you type "kinfocenter" into KRunner, not sure if 
it uses the `Exec` for that if this name is in the desktop file somewhere other 
than that.
  
  
  +1, would be nice to keep the old name around somehow for compatibility. We 
are shooting for enterprise-grade after all, and those folks hate this kind of 
renaming that breaks their custom scripts.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-24 Thread Kai Uwe Broulik 
broulik added a comment.


  Would it make sense to keep a `kinfocenter` script that just launchers 
`systemsettings5 -i` for compat?
  Does it still show up if you type "kinfocenter" into KRunner, not sure if it 
uses the `Exec` for that if this name is in the desktop file somewhere other 
than that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-24 Thread David Edmundson 
davidedmundson added a comment.


  Assuming the other gets in, ship it!

INLINE COMMENTS

> CMakeLists.txt:25
>  Crash
>  DBusAddons
>  DocTools

We can probably get rid of at least this. Maybe quite a few others

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

2020-01-24 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Remove the binary, only install the modules and categories.
  The categories have been reorganized a bit to be compatible with 
SystemSettigns

REPOSITORY
  R102 KInfoCenter

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26896

AFFECTED FILES
  CMakeLists.txt
  Categories/CMakeLists.txt
  Categories/basicinformation.desktop
  Categories/detailedinformation.desktop
  Categories/deviceinfocategory.desktop
  Categories/graphicalinfocategory.desktop
  Categories/kinfocentercategory.desktop
  Categories/networkinfocategory.desktop
  Modules/about-distro/src/about-distro.desktop
  Modules/energy/kcm_energyinfo.desktop
  Modules/fileindexermonitor/kcm_fileindexermonitor.desktop
  Modules/memory/kcm_memory.desktop
  ToolTips/tooltipmanager.cpp
  ToolTips/tooltipmanager.h
  config-X11.h.cmake
  config-project-version.h.cmake
  infocenter.cpp
  infocenter.h
  infokcmmodel.cpp
  infokcmmodel.h
  infokcmproxymodel.cpp
  infokcmproxymodel.h
  kcmcategoryitem.cpp
  kcmcategoryitem.h
  kcmcontainer.cpp
  kcmcontainer.h
  kcmtreeitem.cpp
  kcmtreeitem.h
  kinfocenterui.rc
  main.cpp
  main.h
  org.kde.kinfocenter.desktop
  sidepanel.cpp
  sidepanel.h

To: mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart