D27037: [Notifications] Fixup setSourceModel
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:1c0c8ddef430: [Notifications] Fixup setSourceModel (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27037?vs=74698=74984#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27037?vs=74698=74984 REVISION DETAIL https://phabricator.kde.org/D27037 AFFECTED FILES libnotificationmanager/limitedrowcountproxymodel.cpp libnotificationmanager/notificationgroupcollapsingproxymodel.cpp To: broulik, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27037: [Notifications] Fixup setSourceModel
davidedmundson added a comment. QAbstractSortFilterProxyModel has docs that say you need it, but QSortFilterProxyModel which you inherit from does reset the model in setSourceModel. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27037 To: broulik, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27037: [Notifications] Fixup setSourceModel
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Qt says to do a proper model reset in this method. I also noticed something funky going on with the `LimitedRowCountProxyModel` not showing any data which went away with this. TEST PLAN 5.18 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27037 AFFECTED FILES libnotificationmanager/limitedrowcountproxymodel.cpp libnotificationmanager/notificationgroupcollapsingproxymodel.cpp To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart