D27072: [Colors KCM] Fix roles mixup
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
There were two role enums that became out of sync, breaking e.g. editing user
themes ("override" mode).
TEST PLAN
5.18
I can edit my own themes directly without Save As again
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27072
AFFECTED FILES
kcms/colors/colors.cpp
kcms/colors/colors.h
kcms/colors/filterproxymodel.cpp
To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27072: [Colors KCM] Fix roles mixup
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch, this had been mildly bugging me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27072 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27072: [Colors KCM] Fix roles mixup
This revision was automatically updated to reflect the committed changes. Closed by commit R119:43001f7977af: [Colors KCM] Fix roles mixup (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27072?vs=74807&id=74899 REVISION DETAIL https://phabricator.kde.org/D27072 AFFECTED FILES kcms/colors/colors.cpp kcms/colors/colors.h kcms/colors/filterproxymodel.cpp To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
