D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2c832dbdd087: Fix duplicate results for sessions, 
simplify and optimize (authored by alex, committed by cullmann).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27109?vs=74875=75775

REVISION DETAIL
  https://phabricator.kde.org/D27109

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Alexander Lohnau]

alex added a comment.


  No problem, thanks for reviewing :-)

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann added a comment.


  Upsa ;) missed that this is in plasma addons, not in the session launcher 
applet we have in our repo, ignore my comment about the invent stuff ;=)

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann added a comment.


  Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, 
but I will just apply this via arc.

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Improved output seems fine for me, thanks for taking care.

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Alexander Lohnau]

alex updated this revision to Diff 74875.
alex added a comment.


  Minor formatting improvements

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27109?vs=74874=74875

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, broulik, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Alexander Lohnau]

alex created this revision.
alex added reviewers: broulik, davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The sessions are now only loaded when the plugin is initialized or the folder 
changes.
  Additionally the option to search for a session just by the name has been 
removed,
  because Kate itself provides this functionality (demonstated in screenshots).

TEST PLAN
  Create sessions, they should show up like in the last two screenshots.
  After testing this create/edit/delete sessions, the changes should be 
automatically applied.
  Before:
  F8078772: before_duplicate_launch_entries.png 

  After:
  F8078770: after_no_duplicates.png 
  Search with "kate" prefix should work as before:
  F8078771: works_same.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, broulik, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart