D27113: Delete cache when resetting user settings

[Filip Fila]

filipf added a comment.


  In D27113#604956 , @davidedmundson 
wrote:
  
  > Can you explain what happens that would require us to delete the cache and 
why this isn't the case when you change colour themes on a regular session.
  
  
  The difference is that we don't change the color scheme when resetting SDDM 
user settings, we delete kdeglobals. In a regular session the color scheme 
entry only gets updated, not deleted.
  
  I see that it could be suggested that we reset the colors to Breeze instead 
of deleting them, but I know some distributions (e.g. Manjaro) hack SDDM 
theming from somewhere else so we shouldn't override that. SDDM's default state 
is an empty `.config` dir anyway.
  
  Back to the issue at hand - these theme cache files seem unreadable to me, 
but what I presume happens is that a Plasma theme gets generated with a 
specific color scheme and when there is no other color scheme specified to 
recolor the Plasma theme, the cached theme recolored with old colors ends up 
being used.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27113

To: filipf, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27113: Delete cache when resetting user settings

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Can you explain what happens that would require us to delete the cache and 
why this isn't the case when you change colour themes on a regular session.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27113

To: filipf, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27113: Delete cache when resetting user settings

[Filip Fila]

filipf created this revision.
filipf added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Apparently SDDM's cache is not always allowing for a clean reset of user 
theming preferences so we can delete it when performing the reset.
  
  BUG: 417057
  FIXED-IN: 5.18.0

TEST PLAN
  The folder was deleted (but got created again by SDDM when logging in again)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  delete-sddm-cache (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27113

AFFECTED FILES
  sddmauthhelper.cpp

To: filipf, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart