D27199: [WIP][Applet]Update layout based on T10470
gvgeo updated this revision to Diff 75498. gvgeo added a comment. Route no.2 Added line and Warning messages. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75280=75498 BRANCH layout2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27199 AFFECTED FILES applet/contents/ui/ConnectionItem.qml applet/contents/ui/DetailsText.qml applet/contents/ui/Header.qml applet/contents/ui/ListItem.qml applet/contents/ui/PopupDialog.qml applet/contents/ui/Toolbar.qml applet/contents/ui/TrafficMonitor.qml applet/contents/ui/main.qml libs/models/networkmodel.h libs/models/networkmodelitem.cpp To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27199: [WIP][Applet]Update layout based on T10470
gvgeo planned changes to this revision. gvgeo added a comment. Background margins and big connect button is a problem. Other themes break as it is now. Also creates an awkward empty space between label and details. Which direction to take? 1. Remove button and replace with a text. Bold when hover to click. 2. Remove listitem background. 3. Increase the available connections height, to match the other's height. 4. Something else? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27199: [WIP][Applet]Update layout based on T10470
gvgeo updated this revision to Diff 75280. gvgeo added a comment. Fixed hiding function of the separator. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75150=75280 BRANCH layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D27199 AFFECTED FILES applet/contents/ui/ConnectionItem.qml applet/contents/ui/DetailsText.qml applet/contents/ui/Header.qml applet/contents/ui/PopupDialog.qml applet/contents/ui/Toolbar.qml applet/contents/ui/TrafficMonitor.qml applet/contents/ui/main.qml libs/models/networkmodel.h libs/models/networkmodelitem.cpp To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27199: [WIP][Applet]Update layout based on T10470
manueljlin added a comment. I think that it should use a footer to be consistent with the other ones REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27199: [WIP][Applet]Update layout based on T10470
gvgeo planned changes to this revision. gvgeo added a comment. Found a better way to hide the separator. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27199: [WIP][Applet]Update layout based on T10470
gvgeo updated this revision to Diff 75150. gvgeo edited the summary of this revision. gvgeo added a comment. Remove active connections section. I had a typo in my script. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75129=75150 BRANCH layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D27199 AFFECTED FILES applet/contents/ui/ConnectionItem.qml applet/contents/ui/DetailsText.qml applet/contents/ui/Header.qml applet/contents/ui/PopupDialog.qml applet/contents/ui/Toolbar.qml applet/contents/ui/TrafficMonitor.qml applet/contents/ui/main.qml libs/models/networkmodelitem.cpp To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27199: [WIP][Applet]Update layout based on T10470
gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. gvgeo requested review of this revision. REVISION SUMMARY Need help/ideas: Have a problem to disable highlight of List Item when holding the mouse button. The way to display the line above the available connections is bad. Just hiding active connections section, haven't a better way. I've added 3 lines with a `// TODO Fix bind loop messages for width.` for 2 pre-existing issues. I tried to solve them, but failed. Note sure if they have place in code. Thoughts on the layout. Note: I cannot build. So... I test only the qml changes. REPOSITORY R116 Plasma Network Management Applet BRANCH layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D27199 AFFECTED FILES applet/contents/ui/ConnectionItem.qml applet/contents/ui/DetailsText.qml applet/contents/ui/Header.qml applet/contents/ui/PopupDialog.qml applet/contents/ui/Toolbar.qml applet/contents/ui/TrafficMonitor.qml applet/contents/ui/main.qml libs/models/networkmodelitem.cpp To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
