D27257: [Applet]Move toolbar to the bottom

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  you can close this task if you want, after talking a bit over T10470 
 it's better to use headers instead of 
footers

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo added a comment.


  The was plan to move them all to the bottom, and there are patches for most 
of them. There is a recent small discussion about it in T10470 
.

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[Anthony Fieroni]

anthonyfieroni added a comment.


  Why? That's make huge inconsistency, bluetooth applet has it on top, battery 
and brightness too.

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo updated this revision to Diff 75293.
gvgeo added a comment.


  For some reason arc send both patches together here.
  Updated with diff.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27257?vs=75291&id=75293

REVISION DETAIL
  https://phabricator.kde.org/D27257

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo updated this revision to Diff 75291.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Requested change

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27257?vs=75279&id=75291

BRANCH
  flip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27257

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[Nathaniel Graham]

ngraham added a comment.


  While you're at it, can you center the `disabledMessage` label and make it a 
disabled Level 3 heading? See D27219 .

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27257

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27257: [Applet]Move toolbar to the bottom

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
gvgeo requested review of this revision.

REVISION SUMMARY
  Based on T10470 .
  
  Added line between search text field and buttons row.
  Added disabled wifi, mobile, airplane mode messages.
  And a `No available connections` message with a 5 second delay.
  Replaced GridLayout of toolbar with RowLayout.
  
  Depends on D27199 .

TEST PLAN
  Use buttons of the toolbar and make sure the correct message appears,
  with appropriate delay.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  flip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27257

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart