D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a comment.


  Fixed better in D27628 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a comment.


  No, it's still broken for me even with that commit. :(
  
  F8128762: photo_2020-02-24_07-26-43.jpg 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[Marco Martin]

mart closed this revision.
mart added a comment.


  this has been superseeded by  R242:ba0b637de94a 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a comment.


  In D27260#611545 , @davidedmundson 
wrote:
  
  > It still sounds like you're saying "we've just made a breaking change in 
frameworks "
  
  
  I mean... yeah. :/ It's kind of a lousy situation since the Frameworks change 
fixed a bug, but regressed this code since we were doing it wrong here in a way 
that isn't compatible with the correct implementation.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[David Edmundson]

davidedmundson added a comment.


  FWIW, Plasma 5.17 uses PC2, so I have no real objections to this patch in the 
context of this patch. I'm only questioning if that frameworks change is safe, 
given if it is causing changes elsewhere

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[David Edmundson]

davidedmundson added a comment.


  It still sounds like you're saying "we've just made a breaking change in 
frameworks "

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  @mart, @davidedmundson
  
  So the PC3 ToolButton change just went in anyway via D27396 
. So we now need to fix this somehow or 
else it'll be mega broken looking. If we fix it by landing this patch on 
master, here's how it will look for people who get the frameworks change but 
have to wait 4 months until the next major Plasma version: F8103598: 
Screenshot_20200214_063636.png 
  
  If we land this on the stable branch, here's how it will look for people who 
get the Plasma change but never get the Frameworks change: F8103650: 
Screenshot_20200214_071459.PNG 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham added a comment.


  Hmm, good point. Should we not fix the bug in the PC3 toolbutton? How should 
we proceed?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[David Edmundson]

davidedmundson added a comment.


  workspace changes required as a result of a frameworks change raises questions
  
  What happens to users of Plasma 5.17 with the D27221 
 applied and not this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

To: ngraham, #plasma, ndavis
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27260: [applets/systemtray] Set pin button's size correctly

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Depends on D27221 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-pin-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27260

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart