D27261: [Folder view] Fix binding loop on width
gvgeo added a comment. I logged with my main account and I get lots of file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17: QML Label: Binding loop detected for property "width" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27261 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b1cc98f0959: [Folder view] Fix binding loop on width (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75470=75471 REVISION DETAIL https://phabricator.kde.org/D27261 AFFECTED FILES containments/desktop/package/contents/ui/FolderItemDelegate.qml To: ngraham, #plasma, davidedmundson Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
ngraham updated this revision to Diff 75470. ngraham added a comment. One more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75469=75470 BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D27261 AFFECTED FILES containments/desktop/package/contents/ui/FolderItemDelegate.qml To: ngraham, #plasma, davidedmundson Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
ngraham updated this revision to Diff 75469. ngraham added a comment. Use identical margins; don't change the visuals at all (should be done in another patch if necessary) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75427=75469 BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D27261 AFFECTED FILES containments/desktop/package/contents/ui/FolderItemDelegate.qml To: ngraham, #plasma, davidedmundson Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's technically different to before. The old code had half a small margin each side. Generally speaking bug fixes shouldn't change things, as then you're mixing different types of task. REPOSITORY R119 Plasma Desktop BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D27261 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
gvgeo added a comment. Also adds smallSpacing at the top. It would not look right with Plasma Components Label, which already has empty space top and bottom. PC3 on the other hand has none... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27261 To: ngraham, #plasma Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
ngraham updated this revision to Diff 75427. ngraham added a comment. Re-add margins, and also add missing bottomMargin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75285=75427 BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D27261 AFFECTED FILES containments/desktop/package/contents/ui/FolderItemDelegate.qml To: ngraham, #plasma Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
gvgeo added a comment. This removes the smallSpacing. Text will touch the edges. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27261 To: ngraham, #plasma Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27261: [Folder view] Fix binding loop on width
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This fixes the binding loop and replaces a complicated bit of code with something much simpler. TEST PLAN No more binding loop warning when running `plasmashell` on the CLI No meaningful difference in appearance for every combination of icon size and label width in icon view REPOSITORY R119 Plasma Desktop BRANCH fix-folderview-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D27261 AFFECTED FILES containments/desktop/package/contents/ui/FolderItemDelegate.qml To: ngraham, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
