D27282: [Applet]Correct raise max volume functions for mic

2020-02-17 Thread Nathaniel Graham
ngraham added a comment.


  Looks like it.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27282

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27282: [Applet]Correct raise max volume functions for mic

2020-02-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:06e9e3eebf18: [Applet]Correct raise max volume functions 
for mic (authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27282?vs=75355&id=75882

REVISION DETAIL
  https://phabricator.kde.org/D27282

AFFECTED FILES
  applet/contents/ui/main.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27282: [Applet]Correct raise max volume functions for mic

2020-02-11 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Everyone else good with this?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27282

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27282: [Applet]Correct raise max volume functions for mic

2020-02-10 Thread George Vogiatzis
gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Correct osd source devices display when `Raise maximum volume` is enabled.
  Lower to normal volume when disabling `Raise maximum volume` if the
  source device volume was set higher than 100%.

TEST PLAN
  Use shortcut keys for microphone (Volume Up/Down/Mute), with and
  without the "Raise maximum volume". Correct info must be shown.
  
  Set source device(mic) volume higher than 100% and disable "Raise
  maximum volume". Volume should be lowered to 100%.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27282

AFFECTED FILES
  applet/contents/ui/main.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart