D27365: fix condition in KonsoleProfiles::run

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:f0431c95a895: fix condition in KonsoleProfiles::run 
(authored by McPain, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27365?vs=75596=75929

REVISION DETAIL
  https://phabricator.kde.org/D27365

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp

To: McPain, heikobecker, ngraham
Cc: ngraham, alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for your patch @alex. However since this is a targeted bugfix, I would 
like to land it now on the stable branch. Since your patch includes 
refactoring, it needs to go into the next release. I'll land this now, and then 
you can remove this bugfix from your patch. Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

To: McPain, heikobecker, ngraham
Cc: ngraham, alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Alexander Lohnau]

alex added a comment.


  Hello, 
  I have already created a patch for this (and some other improvements) which 
is currently waiting to be reviewed: https://phabricator.kde.org/D27098

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

To: McPain, heikobecker
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Oleg Solovyov]

McPain added a comment.


  Happens to be a regression after 2f3bcfa 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

To: McPain, heikobecker
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27365: fix condition in KonsoleProfiles::run

[Oleg Solovyov]

McPain created this revision.
McPain added a reviewer: heikobecker.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  Looks like there's a typo and it's not intended to exec "konsole --profile" 
with empty profile string because the funxtion returns early when profile is 
not empty.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27365

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp

To: McPain, heikobecker
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart