D27381: [sidebar] Resolve changes in module before switching
This revision was automatically updated to reflect the committed changes. Closed by commit R124:979419d7430d: [sidebar] Resolve changes in module before switching (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27381?vs=75635=75687 REVISION DETAIL https://phabricator.kde.org/D27381 AFFECTED FILES sidebar/SidebarMode.cpp To: davidedmundson, #plasma, bport, ngraham Cc: ngraham, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27381: [sidebar] Resolve changes in module before switching
ngraham accepted this revision. ngraham added a comment. ^^ same REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 To: davidedmundson, #plasma, bport, ngraham Cc: ngraham, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27381: [sidebar] Resolve changes in module before switching
bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Can reproduce bug and fix work as expected REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 To: davidedmundson, #plasma, bport Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27381: [sidebar] Resolve changes in module before switching
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY After some refactoring we close the module before checking if there are unsaved changes. We then try to resolve changes on the new KCM that we've just opened, which never has changes. BUG: 416834 Fixed-in: 5.18.1 TEST PLAN Opened colours in systemsettings changed it switched to another kcm Did the same from within a search opened kinfocenter no prompts REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 AFFECTED FILES sidebar/SidebarMode.cpp To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
