D27386: Set toolbox to invisble when it's invisible
This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a48de1efa22: Set toolbox to invisble when its hidden (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27386?vs=75647=75683 REVISION DETAIL https://phabricator.kde.org/D27386 AFFECTED FILES toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27386: Set toolbox to invisble when it's invisible
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice find! Fixes the bug and makes sense to me. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27386 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27386: Set toolbox to invisble when it's invisible
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY opacity was bound to editMode, but this did not affect visibility or enabled. Not only is this somewhat wasteful, enabled is very important as otherwise shortcuts for buttons get intercepted to match the accelerator applied to the internal buttons. This breaks all the multi-key shortcuts that plasma uses as alt+d gets taken. BUG: 416695 FIXED-IN: 5.18.1 TEST PLAN Mad gammaray skillz to find the bug Checked alt+d, a now opens the widget explorer Checked edit mode through the context menu still showed the toolbox REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27386 AFFECTED FILES toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
