D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1123cc4d0b59: [desktoppackage] Fix layout when an applet 
has no custom config modules (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27398?vs=75680=75842

REVISION DETAIL
  https://phabricator.kde.org/D27398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: davidedmundson, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D27398#611564 , @davidedmundson 
wrote:
  
  > >> This patch fixes the issue, but I do still see the sidebar
  >
  > I meant  to phrase that as
  >
  > this patch completes the removal of the code, so that we always show the 
sidebar
  
  
  Gotcha.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[David Edmundson]

davidedmundson added a comment.


  > I don't get why it would overlap if it's not visible since we're in a 
RowLayout here?
  
  Because the background to the categories view isn't in the categories view. 
  There's some rectangles at the top that don't update. The content is clashing 
with these.
  
  Fixing that would be an alternate solution to the problem

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[David Edmundson]

davidedmundson added a comment.


  >> This patch fixes the issue, but I do still see the sidebar
  
  I meant  to phrase that as
  
  this patch completes the removal of the code, so that we always show the 
sidebar

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> AppletConfiguration.qml:167
>  Layout.fillHeight: true
> -visible: (configDialog.configModel ? 
> configDialog.configModel.count : 0) + globalConfigModel.count > 1
> +visible: true
>  Layout.maximumWidth: units.gridUnit * 7

Can you instead bind this to the count of the three `Repeater`s below? I don't 
get why it would overlap if it's not visible since we're in a `RowLayout` here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[Nathaniel Graham]

ngraham added a comment.


  This patch fixes the issue, but I do still see the sidebar with only one 
category in it: F8103697: Screenshot_20200214_073711.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27398

To: davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There was some broken code to hide the sidebar when we only have one
  module. However at some point it seems half was removed, half wasn't.
  
  This leads to the content overlapping the sidebar frame, but the sidebar 
  was invisible and it looks generally broken.
  
  This patch completes the removal.
  
  BUG: 410770

TEST PLAN
  Opened touchpad KCM
  Saw the one module (keyboard shortcuts)
  Sidebar was visible, and nothing was overlapping

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart