D27402: Make it possible to change the sorting when searching

[Nathaniel Graham]

ngraham added a comment.


  I'm on Tumbleweed and everything is up to date, but hmm, I see that 
libappstream is still at 0.12.7, not 0.12.10, the current release. I wonder why 
that is.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Aleix Pol Gonzalez]

apol added a comment.


  In D27402#611754 , @ngraham wrote:
  
  > Being able to sort search results in different ways is a nice feature for 
sure. But the desire for it arises from dissatisfaction with the default 
"relevance" search results. We might want to still do this, but the pressure 
for it could be reduced if the relevance algorithm returned more relevant 
results.
  
  
  This was supposedly improved on the last libappstream releases. Can you check 
that you're on the last stable release?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Nathaniel Graham]

ngraham added a comment.


  Being able to sort search results in different ways is a nice feature for 
sure. But the desire for it arises from dissatisfaction with the default 
"relevance" search results. We might want to still do this, but the pressure 
for it could be reduced if the relevance algorithm returned more relevant 
results.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Aleix Pol Gonzalez]

apol added a comment.


  In D27402#611597 , @ngraham wrote:
  
  > When you switch from relevance to something else, that entry *disappears 
entirely* from the menu! That's rather odd. You should be able to return to 
sorting by relevance if you switch to a different sort order and don't like the 
presentation.
  
  
  Right, should. We'd have to keep a copy of every resource which is quite 
dangerous for several reasons and would need a bunch of duplicated code. I'd 
say the question is whether this is an improvement over the status quo or not.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  When you switch from relevance to something else, that entry *disappears 
entirely* from the menu! That's rather odd. You should be able to return to 
sorting by relevance if you switch to a different sort order and don't like the 
presentation.

INLINE COMMENTS

> ApplicationsListPage.qml:84
> +ActionGroup.group: sortGroup
> +text: i18n("Relevancy")
> +checkable: true

"Relevance"

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27402

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27402: Make it possible to change the sorting when searching

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  We were hiding it because sorting wouldn't work when we have the relevancy 
on, so now we'll disable it when searching something else.
  
  BUG: 399502

TEST PLAN
  Used it, seems to work fine.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27402

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  libdiscover/resources/ResourcesProxyModel.cpp
  libdiscover/resources/ResourcesProxyModel.h

To: apol, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart