D27436: Use task rather than tabs

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  This will utterly break with every third party theme.
  If we were to do this we would need to introduce a dedicated "applet is open" 
highlight item or some property to tell it to use tasks for that purpose.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg, ngraham, ndavis, broulik
Cc: broulik, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  Actually, after some use, I don't think this is the best effect to use. I 
will investigate more.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  avoid_tabs_for_applets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This is more semantically correct and a visual improvement IMO. Looks fine to 
me with Breeze dark and light but we should probably wait for confirmation from 
heavy Breeze Dark users.
  
  I think it's fine as-is with the built-in margins, though removing them in 
the SVG is fine; changing the appearance of the plasma theme SVGs doesn't 
impact third-party themes at all. And obviously that needs to be done in a 
separate patch anyway since the SVG lives in a different repo.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  avoid_tabs_for_applets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg, ngraham
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  ...but that does not seem simple and would be inconsistent with the task 
view, so we might want to leave that for another patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  In D27436#612343 , 
@The-Feren-OS-Dev wrote:
  
  > To make it stretch to the borders, simply just remove padding from 
panel.svgz and from the Plasmoid highlight SVG.
  
  
  But themes should be able to set their padding, I can't just remove it. 
Rather, I was trying to give the effect a negative margin equal to the panel 
margin size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  To make it stretch to the borders, simply just remove padding from panel.svgz 
and from the Plasmoid highlight SVG.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Switch from tabs for pressed applets to tasks.
  
  - Tabs should be avoided because it's quite semantically incorrect and I need 
to change tab style in another patch to make them look prettier but that would 
break clicked plasmoids
  - Tasks appearance is consistent with the system tray that's next to it; 
plus, I think that it looks prettier than just a line. It should extend to 
borders, which I could add on next commit here

REPOSITORY
  R119 Plasma Desktop

BRANCH
  avoid_tabs_for_applets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27436

AFFECTED FILES
  desktoppackage/contents/applet/CompactApplet.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart